Make runtest work for external tests again #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier rework had caused external directories not to be searched, even if specified in combination with --external. Fixes SCons#4699. Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
added
the
testsuite
|
@mwichmann simplified path specifications as much as possible in calls to test framework. |
mwichmann
commented
Apr 3, 2025
| @@ -35,7 +35,7 @@ | |||
| import TestRuntest | |||
|
|
|||
| test = TestRuntest.TestRuntest() | |||
| test.subdir('ext', ['ext', 'test'], ['ext', 'test', 'subdir']) | |||
| test.subdir('ext/test/subdir') | |||
There was a problem hiding this comment.
I thought you had to "declare" (create) all the test directories, since I've seen it done that way? This was a quick copy-and-mod of test/runtest/testargv.py, by the way. Ah, I see now the subdir docstring does talk about making intermediates, too.
|
Nope. It calls makedirs() under the hood.
…On Thu, Apr 3, 2025 at 6:18 AM Mats Wichmann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/runtest/external_tests.py
<#4704 (comment)>:
> @@ -35,7 +35,7 @@
import TestRuntest
test = TestRuntest.TestRuntest()
-test.subdir('ext', ['ext', 'test'], ['ext', 'test', 'subdir'])
+test.subdir('ext/test/subdir')
I thought you had to "declare" (create) all the test directories, since
I've seen it done that way? This was a quick copy-and-mod of
test/runtest/testargv.py, by the way. Ah, I see now the subdir docstring
does talk about making intermediates, too.
—
Reply to this email directly, view it on GitHub
<#4704 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUCNF5H7TP2LW7WHTMYGL2XUYLNAVCNFSM6AAAAAB2KKTQX6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMZZHAYTOOBYGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Got it. I thought there was more to it than just make sure the directory exists, and don't know where I got that idea from. Maybe I'll clean up the other runtest tests someday, but of course I have no objection to the change you made - I just copied a test and hacked it without doing further examination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier rework had caused external directories not to be searched, even if specified in combination with
--external.Fixes #4699.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).