Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supera tag, now compatible with larsoft v10 #484

Closed
wants to merge 2 commits into from
Closed

Update supera tag, now compatible with larsoft v10 #484

wants to merge 2 commits into from

Conversation

bear-is-asleep
Copy link
Contributor

@bear-is-asleep bear-is-asleep commented Nov 12, 2024 •
edited
Loading

Description

Updates to Supera to be compatible with larsoft v10. Follows changes in PR#22 in Supera.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • [na] Is this PR related to an open issue / project?
  • [na] Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • [na] Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • [na] Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@bear-is-asleep bear-is-asleep self-assigned this Nov 12, 2024
@ibsafa
Copy link
Contributor

ibsafa commented Dec 3, 2024

These changes were implemented already in this commit 57269e3

@ibsafa ibsafa closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francois-drielsma francois-drielsma Awaiting requested review from francois-drielsma

Assignees

@bear-is-asleep bear-is-asleep

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bear-is-asleep @ibsafa