Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t0CRT to Calibration Ntuple #468

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

afm1g15
Copy link
Contributor

@afm1g15 afm1g15 commented Jun 19, 2024

Add the t0CRT to the calibration ntuple. Needs to have to equivalent pull request in sbnobj (here) also present to work. Adds this extra t0 from Henry's CRT association into the ntuple next to the cathode crossing t0. Also unpicks the Pandora assumed trigger correction if only t0CRT tagged.

@afm1g15 afm1g15 added the enhancement New feature or request label Jul 8, 2024
@afm1g15 afm1g15 requested review from mrmooney and ibsafa July 8, 2024 15:31
Copy link

@mrmooney mrmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ibsafa
Copy link
Contributor

ibsafa commented Jul 18, 2024

trigger build

@ibsafa ibsafa merged commit 6d5a030 into SBNSoftware:develop Jul 18, 2024
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c14:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants