fix list empty string value (#141)

SAP · Feb 11, 2020 · c913e54 · c913e54
1 parent 1e84013
commit c913e54
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/frontend/jest.config.js b/frontend/jest.config.js
@@ -35,9 +35,9 @@ module.exports = {
   ],
   coverageThreshold: {
     "global": {
-      "branches": 91.5,
+      "branches": 91.7,
       "functions": 98.5,
-      "lines": 96.2,
+      "lines": 96.3,
       "statements": 96.3
     }
   }

diff --git a/frontend/src/components/QuestionTypes/QuestionList.vue b/frontend/src/components/QuestionTypes/QuestionList.vue
@@ -52,7 +52,7 @@ export default {
       return undefined;
     },
     errorMessages() {
-      if (_.isEmpty(this.selected)) {
+      if (_.isNil(this.selected)) {
         return this.clickToDisplay;
       }
       
@@ -63,13 +63,15 @@ export default {
     default: {
       immediate: true,
       handler: function(defaultValue) {
-        this.selected = defaultValue;
+        if (!_.isNil(defaultValue)) {
+          this.selected = defaultValue;
+        }
       }
     },
     selected: {
       immediate: true,
       handler: function(selectedValue) {
-        this.currentQuestion.isValid = !_.isEmpty(selectedValue)
+        this.currentQuestion.isValid = !_.isNil(selectedValue)
         this.currentQuestion.answer = selectedValue
         this.updateQuestionsFromIndex(this.questionIndex)
       }