Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Removes IDs From Directory Entitlements Test #557

Merged
merged 1 commit into from
Dec 4, 2023
Merged

test: Removes IDs From Directory Entitlements Test #557

merged 1 commit into from
Dec 4, 2023

Conversation

andre-dossinger
Copy link
Contributor

@andre-dossinger andre-dossinger commented Dec 4, 2023 •
edited by lechnerc77
Loading

Purpose

  • Flexible test recording in various landscapes

Does this introduce a breaking change?

[ ] Yes
[ x  ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ x ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@andre-dossinger andre-dossinger marked this pull request as ready for review December 4, 2023 08:09
@lechnerc77 lechnerc77 added this to the 1.0.0-rc1 milestone Dec 4, 2023
@lechnerc77 lechnerc77 added ignore-for-release All things not to be mentioned in release notes test setup Setup of integration tests labels Dec 4, 2023
lechnerc77
lechnerc77 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lechnerc77
Copy link
Member

Drift detection is okay, due to scope of PR

@lechnerc77 lechnerc77 enabled auto-merge (squash) December 4, 2023 09:31
@lechnerc77 lechnerc77 merged commit 981d060 into main Dec 4, 2023
67 of 73 checks passed
@lechnerc77 lechnerc77 deleted the id-removal branch December 4, 2023 09:38
@lechnerc77
Copy link
Member

Prerequisite for #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

@kuntzed kuntzed Awaiting requested review from kuntzed

Assignees

@andre-dossinger andre-dossinger

Labels
ignore-for-release All things not to be mentioned in release notes test setup Setup of integration tests
Projects
None yet
Milestone
1.0.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@andre-dossinger @lechnerc77