Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deletion of subaccounts under managed directories #545

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the bug Something isn't working label Nov 22, 2023
@lechnerc77 lechnerc77 added this to the 1.0.0-rc1 milestone Nov 22, 2023
@lechnerc77 lechnerc77 self-assigned this Nov 22, 2023
@lechnerc77
Copy link
Member Author

Recreation of test fixtures necessary due to additional call in DELETE to determine parent of subaccount -> Drift detection is okay

@lechnerc77 lechnerc77 enabled auto-merge (squash) November 22, 2023 07:32
@lechnerc77 lechnerc77 requested a review from kuntzed November 22, 2023 07:43
Copy link
Contributor

@kuntzed kuntzed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice change

@lechnerc77 lechnerc77 merged commit fb9b344 into main Nov 27, 2023
14 of 15 checks passed
@lechnerc77 lechnerc77 deleted the issue-544 branch November 27, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deletion of subaccount under directory - authentication error 403
2 participants