Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CXSPA-9076 ACC 264.1 (Level A): Product Configuration _ Link _ Item count not read #19912

Merged
merged 8 commits into from
Jan 23, 2025
Merged

fix: CXSPA-9076 ACC 264.1 (Level A): Product Configuration _ Link _ Item count not read #19912

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4439604
fix: CXSPA-9076 ACC 264.1 (Level A): Product Configuration _ Link _ I…
andreighervan7 Jan 22, 2025
44e37c3
fix: CXSPA-9076ACC 264.1 (Level A): Product Configuration _ Link _ It…
andreighervan7 Jan 22, 2025
1c15ea2
Merge branch 'develop' of https://github.com/SAP/spartacus into featu…
andreighervan7 Jan 22, 2025
c10dd63
Merge branch 'develop' of https://github.com/SAP/spartacus into featu…
andreighervan7 Jan 22, 2025
1b1b715
after code review
andreighervan7 Jan 22, 2025
2bece85
after code review
andreighervan7 Jan 23, 2025
9097498
after code review
andreighervan7 Jan 23, 2025
6dc22a8
Merge branch 'develop' into feature/CXSPA-9076-ACC-2641-Level-A-v22
andreighervan7 Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions projects/storefrontlib/cms-components/navigation/breadcrumb/breadcrumb.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
<nav [attr.aria-label]="'common.breadcrumbs' | cxTranslate" tabindex="-1">
<ol [attr.aria-label]="'common.breadcrumbs' | cxTranslate">
<li *ngFor="let crumb of crumbs$ | async; let last = last">
<a
[routerLink]="crumb.link"
[innerHTML]="crumb.label"
[attr.aria-label]="
<ng-container *ngIf="crumbs$ | async as crumbList">
<nav [attr.aria-label]="'common.breadcrumbs' | cxTranslate" tabindex="-1">
<ol [attr.aria-label]="'common.breadcrumbs' | cxTranslate">
<li *ngFor="let crumb of crumbList; let i = index; let last = last">
<a [routerLink]="crumb.link" [innerHTML]="crumb.label" [attr.aria-label]="
last
? ('common.breadcrumbsCurrentPage' | cxTranslate) +
' ' +
crumb.label
: crumb.label
crumb.label+ (i+1) +' of '+ crumbList.length
: crumb.label + (i+1) +' of '+ crumbList.length
andreighervan7 marked this conversation as resolved.
Show resolved Hide resolved
"
></a>
</li>
</ol>
</nav>
</ng-container>

<!-- TODO: Remove feature flag next major release -->
<ng-container *cxFeature="'a11yPreventSRFocusOnHiddenElements'">
Expand Down
Loading