Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move GooglePay url into default config #19877

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Conversation

Matejk00
Copy link
Contributor

Closes: CXSPA-9216

@Matejk00 Matejk00 requested a review from a team as a code owner January 16, 2025 13:35
@github-actions github-actions bot marked this pull request as draft January 16, 2025 13:36
Copy link
Contributor

@FollowTheFlo FollowTheFlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we'll then have to add exception on Checkmrax with CXSPA-9216 as ref

@Matejk00 Matejk00 marked this pull request as ready for review January 20, 2025 14:52
Copy link

cypress bot commented Jan 20, 2025

spartacus    Run #46768

Run Properties:  status check passed Passed #46768  •  git commit 9c4e46a714 ℹ️: Merge a482ccba5bb0771599bbdcc8f03dedfb645663b8 into 8283000b3ab9b95bacec8f2b9f87...
Project spartacus
Branch Review feature/CXSPA-9216
Run status status check passed Passed #46768
Run duration 04m 22s
Commit git commit 9c4e46a714 ℹ️: Merge a482ccba5bb0771599bbdcc8f03dedfb645663b8 into 8283000b3ab9b95bacec8f2b9f87...
Committer Mateusz Kolasa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft January 20, 2025 15:16
@Matejk00 Matejk00 marked this pull request as ready for review January 21, 2025 07:54
@Matejk00 Matejk00 merged commit 1c29fdc into develop Jan 21, 2025
28 checks passed
@Matejk00 Matejk00 deleted the feature/CXSPA-9216 branch January 21, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants