fix: (CXSPA-9075) fix footer region group labels arialLabel issue. #19875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9075
|
| Run status |
|
| Run duration | 04m 11s |
| Commit |
|
| Committer | Uros Lates |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
requested changes
Jan 17, 2025
| @@ -153,6 +153,8 @@ | |||
| [attr.depth]="getTotalDepth(node)" | |||
| [attr.wrap-after]="node.children.length > wrapAfter ? wrapAfter : null" | |||
| [attr.columns]="getColumnCount(node.children.length)" | |||
| role="group" | |||
There was a problem hiding this comment.
We should keep the role unchanged. This is a list with listitems inside, I am not sure why we would be grouping them all together instead. The aria-label will still be read and this way we are keeping the semantic role. This would affect all implementations of the navigation-ui not just the footer, we need to keep this in mind while testing.
Pio-Bar
approved these changes
Jan 20, 2025
Zeyber
approved these changes
Jan 20, 2025
Merge Checks Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-9075