fix: (CXSPA-8994) - Prevent forced colors from interfering with contrast themes #19871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8994
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | PioBar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
StanislavSukhanov
approved these changes
Jan 16, 2025
Zeyber
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CXSPA-8994
The Spartacus custom high contrast themes should not be affected by external solutions. These contrast themes are tailored to provide good accessibility without sacrificing readability and usability of the app. The same cannot be guaranteed with one-size-fits-all solutions like the Windows/MacOS contrast themes.
Therefore, we should not make changes to accommodate external stylings that users might apply. These can vary greatly and it would be impossible to satisfy all. However, we allow the default theme to be modified so users can still use other solutions if preferred.