CXCDS-13558: Change implementation for Spartacus CAS support #19869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/CXCDS-13558
kpawelczak
reviewed
Jan 15, 2025
integration-libs/cds/src/merchandising/adapters/strategy/cds-merchandising-strategy.adapter.ts
Outdated
Show resolved
Hide resolved
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXCDS-13558
|
| Run status |
|
| Run duration | 03m 47s |
| Commit |
|
| Committer | johannathalmann-SAP |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
projects/storefrontapp/src/app/spartacus/features/cds/cds-feature.module.ts
Outdated
Show resolved
Hide resolved
projects/storefrontapp/src/app/spartacus/features/cds/cds-feature.module.ts
Outdated
Show resolved
Hide resolved
klucerofermin
requested changes
Jan 17, 2025
klucerofermin
approved these changes
Jan 17, 2025
…into feature/CXCDS-13558
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 12m 14s |
| Commit |
|
| Committer | Uros Lates |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
2
|
|
Pending
|
22
|
|
Skipped
|
0
|
|
Passing
|
815
|
| View all changes introduced in this branch ↗︎ | |
kpawelczak
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the feature toggle implementation since we have to support CAS* and non CAS customers for a while.
CAS support should be based on a configuration change.