Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-9007) - Fix 'dialog' is conveyed twice in ConsentManagementDialog #19843

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix: (CXSPA-9007) - Fix 'dialog' is conveyed twice in ConsentManagementDialog #19843

merged 3 commits into from
Jan 13, 2025

Conversation

petarmarkov9449
Copy link
Contributor

@petarmarkov9449 petarmarkov9449 commented Jan 9, 2025 •
edited
Loading

Closes: CXSPA-9007

Fix 'dialog' is conveyed twice in ConsentManagementDialog

Affects: AnonymousConsentDialogComponent

@petarmarkov9449 petarmarkov9449 requested a review from a team as a code owner January 9, 2025 09:07
@github-actions github-actions bot marked this pull request as draft January 9, 2025 09:07
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 9, 2025 09:44
@cypress Cypress
Copy link

cypress bot commented Jan 9, 2025 •
edited
Loading

spartacus    Run #46639

Run Properties:  status check passed Passed #46639  •  git commit cc73de230c ℹ️: Merge b21d9138a141b8d2913fc8e989ea67a7de1ac9cb into d19780bbce47c03f55e300e7ee1f...
Project spartacus
Branch Review feature/CXSPA-9007
Run status status check passed Passed #46639
Run duration 03m 47s
Commit git commit cc73de230c ℹ️: Merge b21d9138a141b8d2913fc8e989ea67a7de1ac9cb into d19780bbce47c03f55e300e7ee1f...
Committer petarmarkov9449
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@petarmarkov9449 petarmarkov9449 requested a review from Zeyber January 9, 2025 10:53
@github-actions github-actions bot marked this pull request as draft January 13, 2025 14:58
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 13, 2025 14:59
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 13, 2025 15:00
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 13, 2025 15:03
@petarmarkov9449 petarmarkov9449 merged commit 125c6a9 into develop Jan 13, 2025
28 checks passed
@petarmarkov9449 petarmarkov9449 deleted the feature/CXSPA-9007 branch January 13, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@sdrozdsap sdrozdsap sdrozdsap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petarmarkov9449 @Zeyber @sdrozdsap