fix: (CXSPA-8997 & 8988) - Resolve Aria Issues in NavigationUIComponent #19782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8997
|
| Run status |
|
| Run duration | 11m 39s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
sdrozdsap
reviewed
Dec 19, 2024
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.html
Outdated
Show resolved
Hide resolved
sdrozdsap
reviewed
Dec 19, 2024
projects/storefrontlib/cms-components/navigation/navigation/navigation-ui.component.ts
Outdated
Show resolved
Hide resolved
sdrozdsap
reviewed
Dec 19, 2024
projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
Outdated
Show resolved
Hide resolved
sdrozdsap
approved these changes
Jan 27, 2025
Zeyber
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CXSPA-8997, CXSPA-8998
Removes invalid aria-level usage on button elements and ensures buttons have a proper accessible name via aria-label or aria-labelledby.
Affects: NavigationUIComponent