review: CXSPA-8968 changes due to review

SAP · Jan 22, 2025 · b00fe77 · b00fe77
1 parent 756d3f3
commit b00fe77
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 11 deletions.
diff --git a/...urator/rulebased/components/attribute/header/configurator-attribute-header.component.html b/...urator/rulebased/components/attribute/header/configurator-attribute-header.component.html
@@ -3,7 +3,7 @@
   {{ 'configurator.attribute.notVisibleAttributeMsg' | cxTranslate }}
 </div>
 
-<div class="cx-header-label-row">
+<div class="cx-header-label-container">
   <label
     id="{{ createAttributeUiKey('label', attribute.name) }}"
     [class.cx-required-error]="showRequiredMessageForDomainAttribute$ | async"

diff --git a/...tor/rulebased/components/attribute/header/configurator-attribute-header.component.spec.ts b/...tor/rulebased/components/attribute/header/configurator-attribute-header.component.spec.ts
@@ -192,6 +192,7 @@ describe('ConfigAttributeHeaderComponent', () => {
     component.groupId = 'testGroup';
     component.attribute.required = false;
     component.attribute.incomplete = true;
+    component.attribute.domainOnDemand = false;
     component.attribute.uiType = Configurator.UiType.RADIOBUTTON;
     component.groupType = Configurator.GroupType.ATTRIBUTE_GROUP;
     component.isNavigationToGroupEnabled = true;
@@ -328,14 +329,14 @@ describe('ConfigAttributeHeaderComponent', () => {
       );
     });
 
-    it('should not render "show more options" button when domainOnDemand is false', () => {
+    it('should not render "Show Options" button when domainOnDemand is false', () => {
       CommonConfiguratorTestUtilsService.expectElementNotPresent(
         expect,
         htmlElem,
         'cx-configurator-show-options'
       );
     });
-    it('should render "show more options" button when domainOnDemand is true', () => {
+    it('should render "Show Options" button when domainOnDemand is true', () => {
       component.attribute.domainOnDemand = true;
       fixture.detectChanges();
       CommonConfiguratorTestUtilsService.expectElementPresent(

diff --git a/...r/rulebased/components/attribute/show-options/configurator-show-options.component.spec.ts b/...r/rulebased/components/attribute/show-options/configurator-show-options.component.spec.ts
@@ -10,7 +10,7 @@ class MockConfiguratorCommonsService {
   readAttributeDomain() {}
 }
 
-describe('ConfiguratorShowOptions', () => {
+describe('ConfiguratorShowOptionsComponent', () => {
   let component: ConfiguratorShowOptionsComponent;
   let fixture: ComponentFixture<ConfiguratorShowOptionsComponent>;
   let htmlElem: HTMLElement;
@@ -43,15 +43,15 @@ describe('ConfiguratorShowOptions', () => {
     expect(component).toBeTruthy();
   });
 
-  it('should render show options button', () => {
+  it('should render "Show Options" button', () => {
     CommonConfiguratorTestUtilsService.expectElementPresent(
       expect,
       htmlElem,
       '.btn'
     );
   });
 
-  it('should delegate to configurator commons service when clicking show more options button', () => {
+  it('should delegate to configurator commons service when clicking "Show Options" button', () => {
     fixture.debugElement.query(By.css('.btn')).nativeElement.click();
     expect(configuratorCommonsService.readAttributeDomain).toHaveBeenCalledWith(
       component.attributeComponentContext.owner,

diff --git a/...urator/rulebased/components/attribute/show-options/configurator-show-options.component.ts b/...urator/rulebased/components/attribute/show-options/configurator-show-options.component.ts
@@ -13,12 +13,16 @@ import { ConfiguratorAttributeCompositionContext } from '../composition/configur
   templateUrl: './configurator-show-options.component.html',
 })
 export class ConfiguratorShowOptionsComponent {
+  @Input() attributeComponentContext: ConfiguratorAttributeCompositionContext;
+
   constructor(
     protected configuratorCommonsService: ConfiguratorCommonsService
   ) {}
 
-  @Input() attributeComponentContext: ConfiguratorAttributeCompositionContext;
-
+  /**
+   * fires a request to read the attribute domain,
+   * so that all options of the attribute become visible on the UI
+   */
   showOptions() {
     this.configuratorCommonsService.readAttributeDomain(
       this.attributeComponentContext.owner,

diff --git a/...-libs/product-configurator/rulebased/core/state/effects/configurator-basic.effect.spec.ts b/...-libs/product-configurator/rulebased/core/state/effects/configurator-basic.effect.spec.ts
@@ -395,7 +395,7 @@ describe('ConfiguratorEffect', () => {
       attributeKey: attributeKey,
     });
 
-    it('should emit update price action abd success action with content in case connector call goes fine', () => {
+    it('should emit update price action and success action with content in case connector call goes fine', () => {
       const readSuccessAction =
         new ConfiguratorActions.ReadConfigurationSuccess(productConfiguration);
       const updatePricesAction = new ConfiguratorActions.UpdatePriceSummary({
@@ -426,7 +426,7 @@ describe('ConfiguratorEffect', () => {
       expect(configEffects.readAttributeDomain$).toBeObservable(expected);
     });
 
-    it('must not emit anything in case source action is not covered', () => {
+    it('should not emit anything in case source action is not covered', () => {
       const action = new ConfiguratorActions.ReadConfiguration({
         configuration: productConfiguration,
         groupId: groupId,

diff --git a/feature-libs/product-configurator/rulebased/styles/_configurator-attribute-header.scss b/feature-libs/product-configurator/rulebased/styles/_configurator-attribute-header.scss
@@ -52,7 +52,7 @@
     display: block;
   }
 
-  .cx-header-label-row {
+  .cx-header-label-container {
     display: flex;
     flex-direction: column;
     .btn {