chore: re-naming

SAP · Jan 9, 2025 · 741bb1f · 741bb1f
1 parent d92b014
commit 741bb1f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/docs/migration/2211_ng18/typescript-manual.doc.md b/docs/migration/2211_ng18/typescript-manual.doc.md
@@ -2,4 +2,4 @@
 
 ## MyAccountV2OrderHistoryService
 
-Method `getOrderDetailsV2` has been removed. Instead directly use `getOrderDetails`.
+Method `getOrderDetails` has been removed. Instead directly use `getOrderDetailsV2`.
diff --git a/feature-libs/order/core/facade/my-account-v2-order-history.service.spec.ts b/feature-libs/order/core/facade/my-account-v2-order-history.service.spec.ts
@@ -179,10 +179,10 @@ describe('MyAccountV2OrderHistoryService', () => {
     });
   });
 
-  describe('getOrderDetails', () => {
+  describe('getOrderDetailsV2', () => {
     it('should load order details when not present in the store', fakeAsync(() => {
       spyOn(userService, 'takeUserId').and.callThrough();
-      const sub = service.getOrderDetails(orderCode).subscribe();
+      const sub = service.getOrderDetailsV2(orderCode).subscribe();
 
       actions$
         .pipe(ofType(OrderActions.LOAD_ORDER_BY_ID), take(1))
@@ -210,7 +210,7 @@ describe('MyAccountV2OrderHistoryService', () => {
       spyOn(userService, 'takeUserId').and.callThrough();
       store.dispatch(new OrderActions.LoadOrderByIdSuccess(order1));
       service
-        .getOrderDetails(orderCode)
+        .getOrderDetailsV2(orderCode)
         .subscribe((data) => {
           expect(data).toEqual(order1);
         })
@@ -232,7 +232,7 @@ describe('MyAccountV2OrderHistoryService', () => {
         })
       );
       service
-        .getOrderDetails('orderX')
+        .getOrderDetailsV2('orderX')
         .subscribe((data) => {
           expect(data).toEqual(undefined);
         })
@@ -242,7 +242,7 @@ describe('MyAccountV2OrderHistoryService', () => {
       spyOn(service as any, 'getOrderDetailsState').and.returnValue(
         of({ success: null, error: undefined, loading: false, value: null })
       );
-      service.getOrderDetails(orderCode).subscribe(() => {
+      service.getOrderDetailsV2(orderCode).subscribe(() => {
         fail('Should not emit any value');
       });
       expect((service as any).getOrderDetailsState).toHaveBeenCalledWith(
@@ -252,7 +252,7 @@ describe('MyAccountV2OrderHistoryService', () => {
   });
   describe('getOrderDetailsWithTracking', () => {
     it('should return order details with consignment tracking', () => {
-      spyOn(service, 'getOrderDetails').and.returnValue(of(order1));
+      spyOn(service, 'getOrderDetailsV2').and.returnValue(of(order1));
       spyOn(service, 'getConsignmentTracking').and.returnValue(of(tracking1));
       service.getOrderDetailsWithTracking(orderCode).subscribe((result) => {
         expect(result).toEqual({
@@ -269,15 +269,15 @@ describe('MyAccountV2OrderHistoryService', () => {
             },
           ],
         });
-        expect(service.getOrderDetails).toHaveBeenCalledWith(orderCode);
+        expect(service.getOrderDetailsV2).toHaveBeenCalledWith(orderCode);
         expect(service.getConsignmentTracking).toHaveBeenCalledWith(
           orderCode,
           consignmentCode
         );
       });
     });
     it('should return order details without consignment tracking', () => {
-      spyOn(service, 'getOrderDetails').and.returnValue(of(order2));
+      spyOn(service, 'getOrderDetailsV2').and.returnValue(of(order2));
       spyOn(service, 'getConsignmentTracking').and.stub();
       service.getOrderDetailsWithTracking(orderCode).subscribe((result) => {
         expect(result).toEqual({
@@ -289,7 +289,7 @@ describe('MyAccountV2OrderHistoryService', () => {
             },
           ],
         });
-        expect(service.getOrderDetails).toHaveBeenCalledWith(orderCode);
+        expect(service.getOrderDetailsV2).toHaveBeenCalledWith(orderCode);
         expect(service.getConsignmentTracking).not.toHaveBeenCalled();
       });
     });

diff --git a/feature-libs/order/core/facade/my-account-v2-order-history.service.ts b/feature-libs/order/core/facade/my-account-v2-order-history.service.ts
@@ -46,7 +46,7 @@ export class MyAccountV2OrderHistoryService {
   getOrderDetailsWithTracking(
     orderCode: string
   ): Observable<OrderView | undefined> {
-    return this.getOrderDetails(orderCode).pipe(
+    return this.getOrderDetailsV2(orderCode).pipe(
       switchMap((order: Order | undefined) => {
         //-----------------> filling consignment tracking
         const orderView: OrderView = { ...order };
@@ -195,7 +195,7 @@ export class MyAccountV2OrderHistoryService {
     });
   }
 
-  getOrderDetails(code: string): Observable<Order | undefined> {
+  getOrderDetailsV2(code: string): Observable<Order | undefined> {
     const loading$ = this.getOrderDetailsState(code).pipe(
       auditTime(0),
       tap((state) => {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,4 +2,4 @@

		## MyAccountV2OrderHistoryService

		Method `getOrderDetailsV2` has been removed. Instead directly use `getOrderDetails`.
		Method `getOrderDetails` has been removed. Instead directly use `getOrderDetailsV2`.