Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crd for service broker #59

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

MarlenKoch
Copy link
Contributor

Feature:

Adding a servicebroker in a subaccount: The btp terraform provider recently added a btp_subaccount_service_broker resource. Using Upjet we can provide a crossplane Kind that leverages the same capabilities.

https://registry.terraform.io/providers/SAP/btp/latest/docs/resources/subaccount_service_broker

Copy link
Member

@sdischer-sap sdischer-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Requires some minor fixes to make the build succeed though (see comments).

test/e2e/subaccount_service_broker_v1alpha1_test.go Outdated Show resolved Hide resolved
test/e2e/subaccount_service_broker_v1alpha1_test.go Outdated Show resolved Hide resolved
@sdischer-sap sdischer-sap merged commit 706119b into SAP:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants