Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicemanager): improve Secret-Data error handling #52

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

MarlenKoch
Copy link
Contributor

Problem:

The error message BindingCredentials can't be created from invalid secret data covers too many different scenarios.

if binding.Clientid == nil || binding.Clientsecret == nil || binding.SmUrl == nil || binding.Url == nil || binding.Xsappname == nil {
return BindingCredentials{}, errors.New(ErrInvalidSecretData)
}

Solution:

This PR introduces more specific error messages that will be returned. It improves the user experience so that users can figure out the cause of the issue.

Copy link

cla-assistant bot commented Dec 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sdischer-sap sdischer-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@sdischer-sap sdischer-sap merged commit 4804cee into SAP:main Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants