Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify content density handling with Fiori Launchpad in more details #172

Merged
merged 17 commits into from
Jan 20, 2025

Conversation

ulasenka
Copy link
Contributor

No description provided.

Copy link

cla-assistant bot commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Nov 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Nov 19, 2024

Hi @ulasenka , thanks for your contribution! We'll look into it and will get back to you.

@KlattG KlattG added follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally labels Dec 18, 2024
@KlattG KlattG requested review from margopolo, petermuessig and flovogt and removed request for petermuessig and margopolo December 19, 2024 15:35
@KlattG
Copy link
Contributor

KlattG commented Dec 20, 2024

@margopolo @petermuessig The Walkthrough tutorials demonstrate how to build a standalone app, so there is no outer shell like the SAP Fiori launchpad that could have set the content density class already. What do you think - should we leave the Walkthroughs as they are then? Or should we mention in the text that care needs to be taken if an app is embedded in the FLP?

Detailed description of the default content density
Updated getter in light of current UI5 best practices
Revert changes to Walkthrough tutorial
Revert changes to Walkthrough tutorial
@KlattG
Copy link
Contributor

KlattG commented Jan 20, 2025

Hi @ulasenka , we have decided not to modify the Walkthrough tutorial as it's not meant to be run in a launchpad environment. We will update the topic How to Use Densities for Controls in the Developer's Guide in line with your suggestions, however. Thanks for your contribution!

@KlattG KlattG added contribution Valuable Contribution type/outdated Something is outdated in the documentation. and removed follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally labels Jan 20, 2025
Copy link

sap-doc-bot bot commented Jan 20, 2025

Thank you for your valuable content contribution, @ulasenka! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@KlattG KlattG self-requested a review January 20, 2025 11:34
@KlattG KlattG merged commit f0d289d into SAP-docs:main Jan 20, 2025
3 checks passed
@KlattG
Copy link
Contributor

KlattG commented Jan 20, 2025

Implemented with a forthcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution type/outdated Something is outdated in the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants