-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify content density handling with Fiori Launchpad in more details #172
Conversation
Describe default values for compact/cozy content density more specifically
|
Hi @ulasenka , thanks for your contribution! We'll look into it and will get back to you. |
docs/03_Get-Started/step-36-content-density-typescript-667aa4a.md
Outdated
Show resolved
Hide resolved
docs/03_Get-Started/step-36-content-density-typescript-667aa4a.md
Outdated
Show resolved
Hide resolved
@margopolo @petermuessig The Walkthrough tutorials demonstrate how to build a standalone app, so there is no outer shell like the SAP Fiori launchpad that could have set the content density class already. What do you think - should we leave the Walkthroughs as they are then? Or should we mention in the text that care needs to be taken if an app is embedded in the FLP? |
Detailed description of the default content density
Updated getter in light of current UI5 best practices
Revert changes to Walkthrough tutorial
Revert changes to Walkthrough tutorial
Hi @ulasenka , we have decided not to modify the Walkthrough tutorial as it's not meant to be run in a launchpad environment. We will update the topic How to Use Densities for Controls in the Developer's Guide in line with your suggestions, however. Thanks for your contribution! |
Thank you for your valuable content contribution, @ulasenka! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply. Your user ID is displayed as follows: Change display name for User ID N where N is your user ID. For example, 53 is the user ID of the user 'qmacro'. Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete. |
Implemented with a forthcoming release. |
No description provided.