Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing codeline for Walkthrough #176

Closed
Dahmspiegel opened this issue Jan 15, 2025 · 7 comments
Closed

Missing codeline for Walkthrough #176

Dahmspiegel opened this issue Jan 15, 2025 · 7 comments
Assignees
Labels
contribution Valuable Contribution type/outdated Something is outdated in the documentation.

Comments

@Dahmspiegel
Copy link

Dahmspiegel commented Jan 15, 2025

Issue description

In the docs/03_Get-Started/step-1-browser-developer-tools-eadd60a.md (Trouble Shooting Totorial / Step 1: Browser Developer Tools / Checking) the Network Tab the "NavigationBar" Element does not show up, cause it is not in the original source code.
So the change to remove it is already applied.

Feedback Type (Optional)

incorrect statement

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

@KvM2
Copy link
Contributor

KvM2 commented Jan 15, 2025

Hi @Dahmspiegel , thanks for your contribution! We'll look into it and will get back to you.

@KvM2
Copy link
Contributor

KvM2 commented Jan 16, 2025

This is related to https://ui5.sap.com/#/topic/eadd60ae907646bbb838866566b23182 and the step under Checking the Network Tab I think: Remove the unnecessary reference to the NavigationBar in the App.controller file. It looks like the source file sample in the tutorial does contain NavigationBar under sap.ui.define but the source file does not (but still did back in 1.171).

@KvM2 KvM2 assigned KvM2 and KlattG Jan 16, 2025
@KvM2 KvM2 added contribution Valuable Contribution follow-up-with/dev Clarification with development needed. labels Jan 16, 2025
Copy link

sap-doc-bot bot commented Jan 16, 2025

Thank you for your valuable feedback contribution, @Dahmspiegel! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@Dahmspiegel
Copy link
Author

Hi,
it seems like there is a very similar error a few pages later. [https://ui5.sap.com/#/topic/04b75eae78ef4bae9b40cd7540ae8bdc] Maybe the solved tasks were added to the source code at some point.
In this case you have to insert a line even though it is already included in the source code.
[4. To improve performance, set the bootstrap parameter data-sap-ui-async to true in the index.html file.]

My SAP Community ID is 1958069

@KvM2
Copy link
Contributor

KvM2 commented Jan 16, 2025

Thanks for letting us know! We are currently looking into this.

Regarding the community user ID: my understanding is that you have to include this in a reply that contains only the ID and nothing else. 😊

@KlattG
Copy link
Contributor

KlattG commented Jan 17, 2025

Hi, it seems like there is a very similar error a few pages later. [https://ui5.sap.com/#/topic/04b75eae78ef4bae9b40cd7540ae8bdc] Maybe the solved tasks were added to the source code at some point. In this case you have to insert a line even though it is already included in the source code. [4. To improve performance, set the bootstrap parameter data-sap-ui-async to true in the index.html file.]

My SAP Community ID is 1958069

Hi @Dahmspiegel , we're currently revising the tutorial to reflect current best practices. For example, we'll substitute the long-deprecated NavigationBar with some other control and take out the data-sap-ui-async=true learning step, which is no longer of great nutritional value to the learner. Will keep you updated.

openui5bot pushed a commit to SAP/openui5 that referenced this issue Jan 17, 2025
Resolves: SAP-docs/sapui5#176

Change-Id: I8c7206b63be38c76a860e420bf5754caf227f747
@KlattG
Copy link
Contributor

KlattG commented Jan 20, 2025

A fix has now been implemented and will appear in one of the next UI5 releases.

@KlattG KlattG closed this as completed Jan 20, 2025
@KlattG KlattG added type/outdated Something is outdated in the documentation. and removed follow-up-with/dev Clarification with development needed. labels Jan 20, 2025
openui5bot pushed a commit to SAP/openui5 that referenced this issue Jan 21, 2025
…eckBox

Resolves: SAP-docs/sapui5#176

Change-Id: I6e11fc4b9e7921cd70f358b7a0ad6ba6b8972fdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution type/outdated Something is outdated in the documentation.
Projects
None yet
Development

No branches or pull requests

3 participants