Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the responsiveness in mobile #7

Open
rkverma2022 opened this issue Jan 1, 2025 · 30 comments
Open

Fix the responsiveness in mobile #7

rkverma2022 opened this issue Jan 1, 2025 · 30 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rkverma2022
Copy link
Member

No description provided.

@rkverma2022 rkverma2022 added bug Something isn't working good first issue Good for newcomers labels Jan 1, 2025
@rkverma2022 rkverma2022 added this to the responsiveness milestone Jan 1, 2025
@Harshil-0707
Copy link
Contributor

I can add responsiveness to your website.

@rkverma2022
Copy link
Member Author

Okay, let me assign to you,, plz fork the main branch of repo and proceed. #happycontribution 😄

@rkverma2022 rkverma2022 pinned this issue Jan 2, 2025
@rkverma2022 rkverma2022 unpinned this issue Jan 2, 2025
@Harshil-0707
Copy link
Contributor

Do you have any design ideas related to mobile layout? If you have any you can mail me I can work on that.

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 2, 2025

I also saw some bugs in UI , do you want me to fix them? If yes then I will try to fix them I cannot guarantee that I will be able to fix them but I will try.

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 2, 2025 via email

@rkverma2022
Copy link
Member Author

Yes plz, for those just create new issue then I can assign to you. It will increase the number of contributions on your profile as well as good to trace.

@Harshil-0707
Copy link
Contributor

Ok,then I will first fix this issue then another.

@rkverma2022
Copy link
Member Author

Perfect,

@Harshil-0707
Copy link
Contributor

Why aren't you using Tailwind CSS?

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 3, 2025 via email

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 3, 2025

Okay . Also you need to refactor your code.

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 3, 2025 via email

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 3, 2025

I was not telling you to switch from react to next to use tailwind css , I can still use tailwind css in react. What I mean to say by "You need to refactor your code" that it is hard to understand.

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 3, 2025 via email

@Harshil-0707
Copy link
Contributor

It's on you I suggest that you should refactor your code by your own. After I finish my work I will tell you that My work is done then merge my branch and then you should refactor your code slowly by your own.

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 3, 2025 via email

@Harshil-0707
Copy link
Contributor

Don't merge the branch until I have finished my work.

@Harshil-0707
Copy link
Contributor

I am having issue because some other peoples are also working on UI of home page so it is raising conflicts I have made changes in home page you can merge it I will work on responsiveness after UI related working is done by others.

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 5, 2025 via email

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 5, 2025 via email

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 5, 2025 via email

@rkverma2022
Copy link
Member Author

Your PR is merged, please share your LinkedIn if you wish so that we can put your contribution on website,

We love to give credit to our contributors

Happy Contribution @Harshil-0707

Community: https://t.me/opensourceproje

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 5, 2025 via email

@rkverma2022
Copy link
Member Author

rkverma2022 commented Jan 5, 2025 via email

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 5, 2025 via email

@rkverma2022
Copy link
Member Author

Due to conflict, we have reverted, plz recreate the PR with the updated code,,

copy and save somewhere (i.e. notepad) the code you added and do the following

  1. plz click on sync fork from the forked repo,

  2. and run
    git pull origin main

  3. Add your code

  4. create PR

This conflict arises due to pushing the older version of code.

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 6, 2025 via email

@Harshil-0707
Copy link
Contributor

My work is done.Now you can merge the pr.If you think somewhere in website needs to be more responsive you can mail me I will do it.

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 6, 2025 via email

@Harshil-0707
Copy link
Contributor

Harshil-0707 commented Jan 6, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants