Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash fixes #229

Merged
merged 11 commits into from
Apr 21, 2024
Merged

Crash fixes #229

merged 11 commits into from
Apr 21, 2024

Conversation

Terence-D
Copy link
Contributor

These are fixes to some crashes I encountered and some enhancements to improve my workflow. Key changes are listed below, please let me know if you have concerns or comments:

Enhancements

  • Context menu Album list - no longer limits to only 10 and sorts by Name
  • Added filter for No Aesthetic Score
  • If a file with matching name exists at Destination during a Move, appends a number to prevent overwrite
  • Provides an error message now when a folder was manually removed
  • Added Refresh to album context menu and display error message if album was first deleted

Fixes

  • Various null checks at startup to prevent crashes
  • Fixed when deleting Images with associated Albums - removes the link in AlbumImage table first
  • Fixed error when selecting No Rating filter but didn't first check Rating
  • Removed storing the Accordion heights - this was causing Albums to not appear if Models were expanded on Startup, no apparent downside
  • When deleting an image, remove from db first before filesystem to prevent images from not being removable if deleted manually first

Terence-D and others added 11 commits February 23, 2024 07:41
@Terence-D
to fix a foreign key error removed images from the album image table
113d6ed
@Terence-D
removed duplicate selecteditems check when deleting
9807b5f 
added check to ensure the count of selected items isn't zero
added fixes for searching
added fixes for Moving files
changed logitc to not overwrite existing images automaticallyremoved duplicate selecteditems check when deleting
added check to ensure the count of selected items isn't zero
@Terence-D
fixed startup crashes behind the scenes
c522f99
@Terence-D
Merge branch 'crash-fixes' of https://github.com/Terence-D/DiffusionT…
e9531af 
…oolkit into crash-fixes
@Terence-D
removed folder height for accordions as it was causing albums to vani…
af01aa6 
…sh if folders was open on startup
@Terence-D
shows all albums by name when right clicking to add to an album
ac0ab03
@Terence-D
added no aesthetic score
69ae8fc 
fixed potential crash if selected no rating but didn't select rating checkbox
@Terence-D
remove from db before deletion to handle cases where the files are re…
3b43b64 
…moved outside of the app
@Terence-D
fixed some potential startup crashes
a199b34
@Terence-D
added refresh to album context menu
810a730 
added check before adding to album that it exists still
@RupertAvery
Merge branch 'master' into crash-fixes
4d42d63
@RupertAvery
Copy link
Owner

Sorry for the delay. Thank you for the changes!

@RupertAvery RupertAvery merged commit d70e938 into RupertAvery:master Apr 21, 2024
1 check passed
@RupertAvery RupertAvery mentioned this pull request Apr 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RupertAvery RupertAvery RupertAvery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Terence-D @RupertAvery