From a59394ec2be1b936b4fd4ffd45f8b4f2b8c8c84a Mon Sep 17 00:00:00 2001 From: sammyette Date: Mon, 16 Sep 2024 13:08:49 -0400 Subject: [PATCH 1/3] feat: make right arrow insert hint text if any is available --- readline/readline.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/readline/readline.go b/readline/readline.go index 627bff49..f79f1650 100644 --- a/readline/readline.go +++ b/readline/readline.go @@ -707,6 +707,11 @@ func (rl *Instance) escapeSeq(r []rune) { rl.renderHelpers() return } + + if len(rl.hintText) != 0 { + // fill in hint text + rl.insert(rl.hintText) + } if (rl.modeViMode == VimInsert && rl.pos < len(rl.line)) || (rl.modeViMode != VimInsert && rl.pos < len(rl.line)-1) { rl.moveCursorByAdjust(1) From b311f24b3f037df791734d3a06edee085a15da01 Mon Sep 17 00:00:00 2001 From: sammyette Date: Sun, 22 Dec 2024 12:07:23 -0400 Subject: [PATCH 2/3] refactor: move hint insert to function --- readline/hint.go | 7 +++++++ readline/readline.go | 6 ++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/readline/hint.go b/readline/hint.go index 6c6a67c2..d0c54fe0 100644 --- a/readline/hint.go +++ b/readline/hint.go @@ -56,3 +56,10 @@ func (rl *Instance) resetHintText() { //rl.hintY = 0 rl.hintText = []rune{} } + +func (rl *Instance) insertHintText() { + if len(rl.hintText) != 0 { + // fill in hint text + rl.insert(rl.hintText) + } +} diff --git a/readline/readline.go b/readline/readline.go index f79f1650..7282071b 100644 --- a/readline/readline.go +++ b/readline/readline.go @@ -708,10 +708,8 @@ func (rl *Instance) escapeSeq(r []rune) { return } - if len(rl.hintText) != 0 { - // fill in hint text - rl.insert(rl.hintText) - } + rl.insertHintText() + if (rl.modeViMode == VimInsert && rl.pos < len(rl.line)) || (rl.modeViMode != VimInsert && rl.pos < len(rl.line)-1) { rl.moveCursorByAdjust(1) From 9475a9f37d814075d7ada0d75a4d41ea2401a269 Mon Sep 17 00:00:00 2001 From: sammyette Date: Sun, 22 Dec 2024 12:09:21 -0400 Subject: [PATCH 3/3] chore: add to changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fd848c52..87a7c47d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,9 @@ # 🎀 Changelog ## Unreleased +### Added +- Forward/Right arrow key will fill in hint text (#327) + ### Fixed - Skip over file and prevent panic if info cannot be retrieved during file completion (due to permission error or anything else)