Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hilbish native pager #240

Merged
merged 45 commits into from
Oct 25, 2023
Merged

feat: hilbish native pager #240

merged 45 commits into from
Oct 25, 2023

Conversation

TorchedSammy
Copy link
Member

@TorchedSammy TorchedSammy commented Feb 18, 2023 •
edited
Loading

adds a lua-written pager command (and library of some sorts)

  • Table of contents
  • Commands
    • Jump to page number
  • Use in doc command
    • Subdoc navigation
    • Fix text getting cut off
  • I have reviewed CONTRIBUTING.md.
  • My commits and title use the Conventional Commit format.
  • I have documented changes and additions in the CHANGELOG.md.

@TorchedSammy TorchedSammy added this to the v2.2 (Poppy) milestone Feb 18, 2023
@TorchedSammy TorchedSammy marked this pull request as draft February 18, 2023 23:58
TorchedSammy and others added 23 commits February 19, 2023 16:53
@TorchedSammy
feat(nature/greenhouse): support setting multiple pages
179bec7
@TorchedSammy
fix(nature/greenhouse): reset line offset when switching pages
ec0692e
@TorchedSammy
chore: merge from master
7531bbf
@TorchedSammy
feat(commands/greenhouse): support reading from pipes
d196799
@TorchedSammy
feat: make doc command use pager
076118d
@TorchedSammy
chore: merge from master
f5fe85e
@TorchedSammy
docs: update doc strings for sink read functions
f9546e1
@TorchedSammy
chore: update branch
4a3ceed
@TorchedSammy
feat: add getChar function to editor interface
b631563 
this is a simple command that returns a single key from the user.
this can be used to read keystrokes in an interactive program
like how greenhouse (the pager) does it
@TorchedSammy
ci: run docgen on prs and every branch
e0d59a3
@TorchedSammy
ci: fix docs action
d5e3185
@TorchedSammy
ci: stop using deprecated method of setting branch name
47582e1
@TorchedSammy @github-actions
docs: [ci] generate new docs
99a121b
@TorchedSammy
ci: remove duplicate run command
2dcae51
@TorchedSammy
chore: merge from upstream
e84a2fb
@TorchedSammy
ci: revert "ci: run docgen on prs and every branch"
157984e 
This reverts commit e0d59a3.
@TorchedSammy
ci: fix branch name
e013ecd
@TorchedSammy
ci: add missing quote
e4c3076
@TorchedSammy
feat: add more keys for readchar function
60f2672
@TorchedSammy
feat(greenhouse): add functions for custom keybinds
713f24a
@TorchedSammy
feat: add table of contents to pager
0bb97a6 
another change in this commit is having a separate render
function for the greenhouse caller to handle ui

this means there isnt a hardcoded space at the bottom to
display command and status line
@TorchedSammy
feat(greenhouse): add command handling
8b672f5
@TorchedSammy
feat(greenhouse): add goto command
11da2c0 
made some other minor changes (in terms of how much it
matters to the user)

the toc page is now a "special page"
in a next commit itll also be used for a help page

cursor gets hidden unless typing a command
@TorchedSammy TorchedSammy marked this pull request as ready for review July 10, 2023 03:40
@TorchedSammy
docs: update
1f5ab90
@TorchedSammy
fix(greenhouse): fix toc disappearing on any key press
ade14a6
@TorchedSammy
fix(commands/greenhouse): set nil page title
9b39d5f
@TorchedSammy
fix(greenhouse): set scroll boundary properly, fix text cutoff
5b4b055 
this means you can no longer scroll away the text until it isnt seen
this commit also fixes text cutoff when using lunacolors
(like in the doc command)
@TorchedSammy
fix: doc command not displaying correct subdocs when using shorthand …
48a06f8 
…api doc access
@TorchedSammy
fix: set old moddocpath
7d0c3f3
@TorchedSammy
fix(greenhouse): print contents properly
b9bb144 
on the last line that can be displayed, don't print with a newline
this removes the space at the end
@TorchedSammy
feat: pager improvements
19bb05f 
- make use of full terminal space properly in doc and greenhouse
commands
- add some info in doc command like currently viewed doc
and description at the bottom instead of top of doc (this makes it persistent)
- add contents function to Greenhouse to allow showing custom contents
in the table of contents (this will be used for lazy loading in the future)
@TorchedSammy
fix: show usage when no args are passed to greenhouse
264043d 
also niced up the display of the page title
@TorchedSammy
fix(greenhouse): add enter bind to goto page on table of contents
554fb00
@TorchedSammy
feat(commands/doc): add subdocs as additional pages
7288f85
@TorchedSammy
fix: dont concat subdocs list if on main page
003100d
@TorchedSammy
fix: correct no files check to compensate for pipes
8fabdf4
@TorchedSammy
fix(commands/greenhouse): remove extra space in title, set pipe page …
d8a7a43 
…title to stdin
@TorchedSammy
docs: add details to changelog
ae356f6
@TorchedSammy
chore: merge from master
e288826
@TorchedSammy TorchedSammy merged commit 78eb657 into master Oct 25, 2023
@TorchedSammy TorchedSammy deleted the pager branch October 25, 2023 04:41
@TorchedSammy TorchedSammy restored the pager branch December 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2 (Poppy)
Development

Successfully merging this pull request may close these issues.
1 participant
@TorchedSammy