Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req-repeat and properties together halt execution after first #38

Open
raphaklaus opened this issue Oct 29, 2024 · 4 comments
Open

req-repeat and properties together halt execution after first #38

raphaklaus opened this issue Oct 29, 2024 · 4 comments

Comments

@raphaklaus
Copy link

Example:

url: http://localhost:3001/price/{{this.ticker}}
show: current_price,last_price_updated_at
properties: current_price,last_price_updated_at
req-repeat: 1000@5

After the first execution, which returns (see here), the loop exits and the properties variable loses its reference, not updating the properties and neither continuing the request repeat logic.

I managed to fix this issue in a local branch just to unblock my work, but that was a nasty fix. Honestly, we would have to figure out how to refactor this plugin because it's becoming hard to build upon from what I saw. Let me know if you want to collab on that.

@Rooyca
Copy link
Owner

Rooyca commented Oct 30, 2024

Hello @raphaklaus,
I've had the idea of redoing this plugin for a while now but I haven't found the time or motivation to undertake the task. Maybe with your help we can give a new life to this plugin. Thank you.

@Rooyca
Copy link
Owner

Rooyca commented Nov 22, 2024

I believe it would be a good idea to do a list with all the features we want (or not) to support. Because the biggest problem with this plugin is that tried to do many things and end up doing them all poorly.

@raphaklaus
Copy link
Author

Right. What is the core motivation of this plugin? I mean, what problem(s) did you have in mind when writing it?

@Rooyca
Copy link
Owner

Rooyca commented Jan 21, 2025

At the beginning this plugin was only intended to make simple GET requests, but over time I added functionalities (maybe not in the best way) that, at the time, seemed interesting to me. Now I don't know which features we should leave and which we should remove, that's why I could use some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants