-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
req-repeat
and properties
together halt execution after first
#38
Comments
Hello @raphaklaus, |
I believe it would be a good idea to do a list with all the features we want (or not) to support. Because the biggest problem with this plugin is that tried to do many things and end up doing them all poorly. |
Right. What is the core motivation of this plugin? I mean, what problem(s) did you have in mind when writing it? |
At the beginning this plugin was only intended to make simple GET requests, but over time I added functionalities (maybe not in the best way) that, at the time, seemed interesting to me. Now I don't know which features we should leave and which we should remove, that's why I could use some help. |
Example:
After the first execution, which
returns
(see here), the loop exits and theproperties
variable loses its reference, not updating the properties and neither continuing the request repeat logic.I managed to fix this issue in a local branch just to unblock my work, but that was a nasty fix. Honestly, we would have to figure out how to refactor this plugin because it's becoming hard to build upon from what I saw. Let me know if you want to collab on that.
The text was updated successfully, but these errors were encountered: