From d02df0c8e8d932be6fe96dbcd762572126770a21 Mon Sep 17 00:00:00 2001 From: Tasso Evangelista Date: Tue, 9 Jan 2024 19:34:01 -0300 Subject: [PATCH] Remove wrapping `describe` calls in tests --- .../fuselage-toastbar/src/ToastBar.spec.tsx | 6 +- .../components/Accordion/Accordion.spec.tsx | 16 +- .../AnimatedVisibility/AnimatedVisibility.tsx | 6 +- .../AutoComplete/AutoComplete.spec.tsx | 32 ++- .../__snapshots__/AutoComplete.spec.tsx.snap | 10 +- .../src/components/Avatar/Avatar.spec.tsx | 32 ++- .../Avatar/__snapshots__/Avatar.spec.tsx.snap | 8 +- .../src/components/Badge/Badge.spec.tsx | 80 +++--- .../src/components/Banner/Banner.spec.tsx | 22 +- .../fuselage/src/components/Box/Box.spec.tsx | 242 +++++++++--------- .../src/components/Button/Button.spec.tsx | 50 +--- .../src/components/Button/IconButton.spec.tsx | 37 +++ .../ButtonGroup/ButtonGroup.spec.tsx | 16 +- .../src/components/Callout/Callout.spec.tsx | 32 ++- .../__snapshots__/Callout.spec.tsx.snap | 14 +- .../src/components/Card/Card.spec.tsx | 32 ++- .../Card/__snapshots__/Card.spec.tsx.snap | 22 +- .../src/components/CardGrid/CardGrid.spec.tsx | 32 ++- .../__snapshots__/CardGrid.spec.tsx.snap | 2 +- .../components/CardGroup/CardGroup.spec.tsx | 32 ++- .../__snapshots__/CardGroup.spec.tsx.snap | 10 +- .../src/components/CheckBox/CheckBox.spec.tsx | 92 ++++--- .../__snapshots__/CheckBox.spec.tsx.snap | 12 +- .../src/components/Chevron/Chevron.spec.tsx | 6 +- .../src/components/Chip/Chip.spec.tsx | 6 +- .../CodeSnippet/CodeSnippet.spec.tsx | 58 ++--- .../src/components/Divider/Divider.spec.tsx | 6 +- .../src/components/Dropdown/Dropdown.spec.tsx | 34 ++- .../components/EmailInput/EmailInput.spec.tsx | 6 +- .../src/components/Field/Field.spec.tsx | 32 ++- .../Field/__snapshots__/Field.spec.tsx.snap | 10 +- .../components/FieldGroup/FieldGroup.spec.tsx | 6 +- .../src/components/Flex/Flex.spec.tsx | 15 +- .../components/FramedIcon/FramedIcon.spec.tsx | 32 ++- .../__snapshots__/FramedIcon.spec.tsx.snap | 10 +- .../src/components/Grid/Grid.spec.tsx | 14 +- .../src/components/Icon/Icon.spec.tsx | 8 +- .../src/components/InputBox/InputBox.spec.tsx | 15 +- .../src/components/InputBox/InputBox.tsx | 7 +- .../src/components/Label/Label.spec.tsx | 32 ++- .../Label/__snapshots__/Label.spec.tsx.snap | 10 +- .../src/components/Margins/Margins.spec.tsx | 24 +- .../src/components/Menu/Menu.spec.tsx | 48 ++-- .../src/components/Message/Message.spec.tsx | 6 +- .../src/components/Modal/Modal.spec.tsx | 32 ++- .../Modal/__snapshots__/Modal.spec.tsx.snap | 16 +- .../MultiSelect/MultiSelect.spec.tsx | 6 +- .../NumberInput/NumberInput.spec.tsx | 8 +- .../src/components/Options/Options.spec.tsx | 6 +- .../components/Pagination/Pagination.spec.tsx | 8 +- .../PasswordInput/PasswordInput.spec.tsx | 8 +- .../ProgressBar/ProgressBar.spec.tsx | 8 +- .../RadioButton/RadioButton.spec.tsx | 4 +- .../__snapshots__/RadioButton.spec.tsx.snap | 8 +- .../SearchInput/SearchInput.spec.tsx | 6 +- .../src/components/Select/Select.spec.tsx | 6 +- .../src/components/Sidebar/Sidebar.spec.tsx | 6 +- .../src/components/Skeleton/Skeleton.spec.tsx | 6 +- .../src/components/Slider/Slider.spec.tsx | 72 +++--- .../src/components/States/States.spec.tsx | 6 +- .../StatusBullet/StatusBullet.spec.tsx | 6 +- .../src/components/Table/Table.spec.tsx | 86 +++---- .../src/components/Tabs/Tabs.spec.tsx | 6 +- .../fuselage/src/components/Tag/Tag.spec.tsx | 6 +- .../TelephoneInput/TelephoneInput.spec.tsx | 6 +- .../TextAreaInput/TextAreaInput.spec.tsx | 6 +- .../components/TextInput/TextInput.spec.tsx | 6 +- .../src/components/Throbber/Throbber.spec.tsx | 6 +- .../src/components/Tile/Tile.spec.tsx | 6 +- .../src/components/ToastBar/ToastBar.spec.tsx | 16 +- .../ToggleSwitch/ToggleSwitch.spec.tsx | 32 ++- .../__snapshots__/ToggleSwitch.spec.tsx.snap | 8 +- .../src/components/Tooltip/Tooltip.spec.tsx | 31 ++- .../src/components/UrlInput/UrlInput.spec.tsx | 6 +- 74 files changed, 776 insertions(+), 879 deletions(-) create mode 100644 packages/fuselage/src/components/Button/IconButton.spec.tsx diff --git a/packages/fuselage-toastbar/src/ToastBar.spec.tsx b/packages/fuselage-toastbar/src/ToastBar.spec.tsx index bc83157c79..e07498865d 100644 --- a/packages/fuselage-toastbar/src/ToastBar.spec.tsx +++ b/packages/fuselage-toastbar/src/ToastBar.spec.tsx @@ -5,8 +5,6 @@ import * as stories from './stories'; const { ToastBarWithData } = composeStories(stories); -describe('[ToastBarWithData Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/Accordion/Accordion.spec.tsx b/packages/fuselage/src/components/Accordion/Accordion.spec.tsx index d4150fee4b..c785ff8ac3 100644 --- a/packages/fuselage/src/components/Accordion/Accordion.spec.tsx +++ b/packages/fuselage/src/components/Accordion/Accordion.spec.tsx @@ -7,15 +7,13 @@ import * as stories from './Accordion.stories'; const { Default } = composeStories(stories); -describe('[Accordion Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); +}); - it('should have no a11y violations', async () => { - const { container } = render(); +it('should have no a11y violations', async () => { + const { container } = render(); - const results = await axe(container); - expect(results).toHaveNoViolations(); - }); + const results = await axe(container); + expect(results).toHaveNoViolations(); }); diff --git a/packages/fuselage/src/components/AnimatedVisibility/AnimatedVisibility.tsx b/packages/fuselage/src/components/AnimatedVisibility/AnimatedVisibility.tsx index 4bead7e05f..2fbe1eea43 100644 --- a/packages/fuselage/src/components/AnimatedVisibility/AnimatedVisibility.tsx +++ b/packages/fuselage/src/components/AnimatedVisibility/AnimatedVisibility.tsx @@ -52,7 +52,11 @@ const AnimatedVisibility = (props: AnimatedVisibilityProps) => { const className = useStyle( css` - animation-duration: 230ms; + ${process.env.NODE_ENV !== 'test' + ? css` + animation-duration: 230ms; + ` + : ''} ${visibility === Visibility.HIDING && css` diff --git a/packages/fuselage/src/components/AutoComplete/AutoComplete.spec.tsx b/packages/fuselage/src/components/AutoComplete/AutoComplete.spec.tsx index 61d95ddecd..518070ccdd 100644 --- a/packages/fuselage/src/components/AutoComplete/AutoComplete.spec.tsx +++ b/packages/fuselage/src/components/AutoComplete/AutoComplete.spec.tsx @@ -13,22 +13,20 @@ const testCases = Object.values(composeStories(stories)).map((Story) => [ withResizeObserverMock(); -describe('[AutoComplete Rendering]', () => { - test.each(testCases)( - `renders %s without crashing`, - async (_storyname, Story) => { - const tree = render(); - expect(tree.baseElement).toMatchSnapshot(); - } - ); +test.each(testCases)( + `renders %s without crashing`, + async (_storyname, Story) => { + const tree = render(); + expect(tree.baseElement).toMatchSnapshot(); + } +); - test.each(testCases)( - '%s should have no a11y violations', - async (_storyname, Story) => { - const { container } = render(); +test.each(testCases)( + '%s should have no a11y violations', + async (_storyname, Story) => { + const { container } = render(); - const results = await axe(container); - expect(results).toHaveNoViolations(); - } - ); -}); + const results = await axe(container); + expect(results).toHaveNoViolations(); + } +); diff --git a/packages/fuselage/src/components/AutoComplete/__snapshots__/AutoComplete.spec.tsx.snap b/packages/fuselage/src/components/AutoComplete/__snapshots__/AutoComplete.spec.tsx.snap index 90d8c62f97..d1433d8342 100644 --- a/packages/fuselage/src/components/AutoComplete/__snapshots__/AutoComplete.spec.tsx.snap +++ b/packages/fuselage/src/components/AutoComplete/__snapshots__/AutoComplete.spec.tsx.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`[AutoComplete Rendering] renders CustomItem without crashing 1`] = ` +exports[`renders CustomItem without crashing 1`] = `
`; -exports[`[AutoComplete Rendering] renders CustomSelected without crashing 1`] = ` +exports[`renders CustomSelected without crashing 1`] = `
{ - render(); - - const slider = screen.getByRole('slider'); - - slider.focus(); - fireEvent.keyDown(slider, { key: 'ArrowRight' }); - fireEvent.keyDown(slider, { key: 'ArrowRight' }); - fireEvent.keyDown(slider, { key: 'ArrowRight' }); - fireEvent.keyDown(slider, { key: 'ArrowRight' }); - - expect(slider.value).toBe('4'); - }); +it('renders without crashing', () => { + render(); +}); + +it('should display the label when passed', () => { + render(); + const label = screen.queryByText('Range'); + expect(label).toBeInTheDocument(); + expect(label?.textContent).toBe('Range'); +}); + +it('should output the defaultValue when passed', () => { + render(); + const output = screen.queryByTestId('slider-output'); + expect(output?.textContent).toBe('25'); +}); + +it('should have two thumbs when multiThumb prop is true', () => { + render(); + const thumbs = screen.queryAllByRole('slider'); + expect(thumbs.length).toBe(2); +}); + +it("should update Thumb's position when Thumb is clicked and dragged", () => { + render(); + + const slider = screen.getByRole('slider'); + + slider.focus(); + fireEvent.keyDown(slider, { key: 'ArrowRight' }); + fireEvent.keyDown(slider, { key: 'ArrowRight' }); + fireEvent.keyDown(slider, { key: 'ArrowRight' }); + fireEvent.keyDown(slider, { key: 'ArrowRight' }); + + expect(slider.value).toBe('4'); }); diff --git a/packages/fuselage/src/components/States/States.spec.tsx b/packages/fuselage/src/components/States/States.spec.tsx index 4be5dd9927..530b25be81 100644 --- a/packages/fuselage/src/components/States/States.spec.tsx +++ b/packages/fuselage/src/components/States/States.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { States } from '.'; -describe('[States Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/StatusBullet/StatusBullet.spec.tsx b/packages/fuselage/src/components/StatusBullet/StatusBullet.spec.tsx index cfabc74ca9..51d7bfd461 100644 --- a/packages/fuselage/src/components/StatusBullet/StatusBullet.spec.tsx +++ b/packages/fuselage/src/components/StatusBullet/StatusBullet.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { StatusBullet } from '.'; -describe('[StatusBullet Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/Table/Table.spec.tsx b/packages/fuselage/src/components/Table/Table.spec.tsx index 873dc800f0..6b62230b8b 100644 --- a/packages/fuselage/src/components/Table/Table.spec.tsx +++ b/packages/fuselage/src/components/Table/Table.spec.tsx @@ -8,62 +8,60 @@ import * as stories from './Table.stories'; const { Default, Selected } = composeStories(stories); -describe('[Table Component]', () => { - it('renders Table without crashing', () => { - render(); - }); +it('renders Table without crashing', () => { + render(
); +}); - it('renders TableRow without crashing', () => { - render(, { - wrapper: ({ children }) => ( -
- {children} -
- ), - }); +it('renders TableRow without crashing', () => { + render(, { + wrapper: ({ children }) => ( + + {children} +
+ ), }); +}); - it('renders TableHead without crashing', () => { - render(, { - wrapper: ({ children }) => {children}
, - }); +it('renders TableHead without crashing', () => { + render(, { + wrapper: ({ children }) => {children}
, }); +}); - it('renders TableBody without crashing', () => { - render(, { - wrapper: ({ children }) => {children}
, - }); +it('renders TableBody without crashing', () => { + render(, { + wrapper: ({ children }) => {children}
, }); +}); - it('renders TableFoot without crashing', () => { - render(, { - wrapper: ({ children }) => {children}
, - }); +it('renders TableFoot without crashing', () => { + render(, { + wrapper: ({ children }) => {children}
, }); +}); - it('renders TableCell without crashing', () => { - render(, { - wrapper: ({ children }) => ( - - - {children} - -
- ), - }); +it('renders TableCell without crashing', () => { + render(, { + wrapper: ({ children }) => ( + + + {children} + +
+ ), }); +}); - it('should have no a11y violations on Default story', async () => { - const { container: defaultContainer } = render(); +it('should have no a11y violations on Default story', async () => { + const { container: defaultContainer } = render(); - const defaultResults = await axe(defaultContainer); - expect(defaultResults).toHaveNoViolations(); - }); + const defaultResults = await axe(defaultContainer); + expect(defaultResults).toHaveNoViolations(); +}); - it('should have no a11y violations on Selected story', async () => { - const { container: selectedContainer } = render(); +it('should have no a11y violations on Selected story', async () => { + const { container: selectedContainer } = render(); - const selectedResults = await axe(selectedContainer); - expect(selectedResults).toHaveNoViolations(); - }); + const selectedResults = await axe(selectedContainer); + expect(selectedResults).toHaveNoViolations(); }); diff --git a/packages/fuselage/src/components/Tabs/Tabs.spec.tsx b/packages/fuselage/src/components/Tabs/Tabs.spec.tsx index b0bf129cdc..8aa75a3c3c 100644 --- a/packages/fuselage/src/components/Tabs/Tabs.spec.tsx +++ b/packages/fuselage/src/components/Tabs/Tabs.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { Tabs } from '.'; -describe('[Tabs Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/Tag/Tag.spec.tsx b/packages/fuselage/src/components/Tag/Tag.spec.tsx index c5b04641f0..7aaa0deb3a 100644 --- a/packages/fuselage/src/components/Tag/Tag.spec.tsx +++ b/packages/fuselage/src/components/Tag/Tag.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { Tag } from '.'; -describe('[Tag Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/TelephoneInput/TelephoneInput.spec.tsx b/packages/fuselage/src/components/TelephoneInput/TelephoneInput.spec.tsx index 7d5cbe55af..35c17b2cae 100644 --- a/packages/fuselage/src/components/TelephoneInput/TelephoneInput.spec.tsx +++ b/packages/fuselage/src/components/TelephoneInput/TelephoneInput.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { TelephoneInput } from '.'; -describe('[TelephoneInput Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/TextAreaInput/TextAreaInput.spec.tsx b/packages/fuselage/src/components/TextAreaInput/TextAreaInput.spec.tsx index 38f5a388f5..db53512dcb 100644 --- a/packages/fuselage/src/components/TextAreaInput/TextAreaInput.spec.tsx +++ b/packages/fuselage/src/components/TextAreaInput/TextAreaInput.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { TextAreaInput } from '.'; -describe('[TextAreaInput]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/TextInput/TextInput.spec.tsx b/packages/fuselage/src/components/TextInput/TextInput.spec.tsx index bc9d399891..5a691a55b6 100644 --- a/packages/fuselage/src/components/TextInput/TextInput.spec.tsx +++ b/packages/fuselage/src/components/TextInput/TextInput.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import { TextInput } from '.'; -describe('[TextInput]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/Throbber/Throbber.spec.tsx b/packages/fuselage/src/components/Throbber/Throbber.spec.tsx index 00b42119bb..cfe0f354fc 100644 --- a/packages/fuselage/src/components/Throbber/Throbber.spec.tsx +++ b/packages/fuselage/src/components/Throbber/Throbber.spec.tsx @@ -6,8 +6,6 @@ import * as stories from './Throbber.stories'; const { Default } = composeStories(stories); -describe('[Throbber Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/Tile/Tile.spec.tsx b/packages/fuselage/src/components/Tile/Tile.spec.tsx index 7c9af6c110..e9a36c62aa 100644 --- a/packages/fuselage/src/components/Tile/Tile.spec.tsx +++ b/packages/fuselage/src/components/Tile/Tile.spec.tsx @@ -3,8 +3,6 @@ import React from 'react'; import Tile from '.'; -describe('[Tile Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); }); diff --git a/packages/fuselage/src/components/ToastBar/ToastBar.spec.tsx b/packages/fuselage/src/components/ToastBar/ToastBar.spec.tsx index 8fd9218621..77ace8ba1c 100644 --- a/packages/fuselage/src/components/ToastBar/ToastBar.spec.tsx +++ b/packages/fuselage/src/components/ToastBar/ToastBar.spec.tsx @@ -4,15 +4,13 @@ import React from 'react'; import { ToastBar } from '.'; -describe('[ToastBar Component]', () => { - it('renders without crashing', () => { - render(); - }); +it('renders without crashing', () => { + render(); +}); - it('should have no a11y violations', async () => { - const { container } = render(); +it('should have no a11y violations', async () => { + const { container } = render(); - const results = await axe(container); - expect(results).toHaveNoViolations(); - }); + const results = await axe(container); + expect(results).toHaveNoViolations(); }); diff --git a/packages/fuselage/src/components/ToggleSwitch/ToggleSwitch.spec.tsx b/packages/fuselage/src/components/ToggleSwitch/ToggleSwitch.spec.tsx index ef2e8c0990..7d5f90fddd 100644 --- a/packages/fuselage/src/components/ToggleSwitch/ToggleSwitch.spec.tsx +++ b/packages/fuselage/src/components/ToggleSwitch/ToggleSwitch.spec.tsx @@ -12,22 +12,20 @@ const testCases = Object.values(composeStories(stories)).map((Story) => [ Story, ]); -describe('[ToggleSwitch Rendering]', () => { - test.each(testCases)( - `renders %s without crashing`, - async (_storyname, Story) => { - const tree = render(); - expect(tree.baseElement).toMatchSnapshot(); - } - ); +test.each(testCases)( + `renders %s without crashing`, + async (_storyname, Story) => { + const tree = render(); + expect(tree.baseElement).toMatchSnapshot(); + } +); - test.each(testCases)( - '%s should have no a11y violations', - async (_storyname, Story) => { - const { container } = render(); +test.each(testCases)( + '%s should have no a11y violations', + async (_storyname, Story) => { + const { container } = render(); - const results = await axe(container); - expect(results).toHaveNoViolations(); - } - ); -}); + const results = await axe(container); + expect(results).toHaveNoViolations(); + } +); diff --git a/packages/fuselage/src/components/ToggleSwitch/__snapshots__/ToggleSwitch.spec.tsx.snap b/packages/fuselage/src/components/ToggleSwitch/__snapshots__/ToggleSwitch.spec.tsx.snap index 17b4fe0e2f..2bd50fcd6d 100644 --- a/packages/fuselage/src/components/ToggleSwitch/__snapshots__/ToggleSwitch.spec.tsx.snap +++ b/packages/fuselage/src/components/ToggleSwitch/__snapshots__/ToggleSwitch.spec.tsx.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`[ToggleSwitch Rendering] renders Checked without crashing 1`] = ` +exports[`renders Checked without crashing 1`] = `