Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Livechat department removed/disabled events for apps #35280

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

KevLehman
Copy link
Member

@KevLehman KevLehman commented Feb 20, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-243

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Feb 20, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (71fc001) to head (8a83708).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35280   +/-   ##
========================================
  Coverage    59.43%   59.43%           
========================================
  Files         2829     2829           
  Lines        68323    68323           
  Branches     15131    15131           
========================================
  Hits         40611    40611           
  Misses       25054    25054           
  Partials      2658     2658           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: 8a83708

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

KevLehman and others added 2 commits February 21, 2025 11:40
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
@KevLehman KevLehman marked this pull request as ready for review February 21, 2025 17:41
@KevLehman KevLehman requested review from a team as code owners February 21, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants