Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional timeout argument to callService #835

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add optional timeout argument to callService #835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72630a5
Add optional timeout argument to callService
bjsowa Dec 18, 2024
58c9ad8
Pass timeout property even if it is undefined
bjsowa Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/core/Service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ export default class Service extends EventEmitter {
* @param {TRequest} request - The service request to send.
* @param {callServiceCallback} [callback] - Function with the following params:
* @param {callServiceFailedCallback} [failedCallback] - The callback function when the service call failed with params:
*/
callService(request, callback, failedCallback) {
* @param {number} [timeout] - Optional timeout, in seconds, for the service call. A non-positive value means no timeout.
* If not provided, the rosbridge server will use its default value.
*/
callService(request, callback, failedCallback, timeout) {
if (this.isAdvertised) {
return;
}
Expand All @@ -71,8 +73,10 @@ export default class Service extends EventEmitter {
id: serviceCallId,
service: this.name,
type: this.serviceType,
args: request
args: request,
timeout: timeout
};

this.ros.callOnConnection(call);
}
/**
Expand Down
Loading