Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skchange integration - base class homogenization #107

Open
RobotPsychologist opened this issue Oct 30, 2024 · 4 comments
Open

skchange integration - base class homogenization #107

RobotPsychologist opened this issue Oct 30, 2024 · 4 comments
Assignees
Labels
sktimedev Work for the team developing our desired changes to sktime

Comments

@RobotPsychologist
Copy link
Owner

No description provided.

@fkiraly
Copy link

fkiraly commented Oct 30, 2024

As described in issue sktime/sktime#7323

I have carried out the most significant parts on the base class level here: sktime/sktime#7342

What remains is:

  • changes to the transform method, to be discussed
  • go through individual classes inheriting from BaseDetector (after this PR) and ensure they comply with the new homogenized interface definitions. There will likely be small issues for each class. As sktime - Test Framework Development #105 progresses, the tests will likely flag up incompatibilities with the API which also need to be fixed.
  • ensure this is aligned with changes to the test framework, see sktime - Test Framework Development #105

Once this is done, we can make changes within skchange itself:

  • skchange to use the BaseDetector from sktime as base class where possible
  • skchange to use the parametrize_with_checks utility from sktime for testing. This is conditional on sktime - Test Framework Development #105.

@RobotPsychologist RobotPsychologist added the sktimedev Work for the team developing our desired changes to sktime label Oct 30, 2024
@alyssadsouza
Copy link
Contributor

👍

@ShivamSingal
Copy link
Contributor

Interested

@RobotPsychologist
Copy link
Owner Author

Closing this because franz, martin, and alex merged previous work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sktimedev Work for the team developing our desired changes to sktime
Development

No branches or pull requests

4 participants