Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update backward ros and patch #23

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Feb 5, 2025

  • as title

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21
Copy link
Contributor Author

wep21 commented Feb 5, 2025

@traversaro How can I rebuild one package which is already added into conda packages?

@traversaro
Copy link
Member

@traversaro How can I rebuild one package which is already added into conda packages?

You need to bump its build number in https://github.com/RoboStack/ros-jazzy/blob/main/pkg_additional_info.yaml .

@traversaro
Copy link
Member

Difference between 1.0.6 and 1.0.7 : pal-robotics/backward_ros@1.0.6...1.0.7 . The changes are mostly in CMake, so I think we are safe from the ABI point of view.

@wep21
Copy link
Contributor Author

wep21 commented Feb 5, 2025

Bumping build number in pkg_additional_info.yaml works fine on my PC, while building backward_ros seems to be skipped in github actions. 🤔

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 force-pushed the update-backward-ros branch from e9f10b1 to 282edd2 Compare February 5, 2025 17:00
@traversaro
Copy link
Member

There is some logic that does not build recipes is the related vinca file is not modified. If you do a dummy modification to the corresponding file it should build.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 force-pushed the update-backward-ros branch from f6b144c to 80b0184 Compare February 5, 2025 17:24
@Tobias-Fischer Tobias-Fischer merged commit ea39ca6 into RoboStack:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants