Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor+router: move controller to router and better error handling #140

Merged
merged 5 commits into from
Dec 11, 2018
Merged

refactor+router: move controller to router and better error handling #140

merged 5 commits into from
Dec 11, 2018

Conversation

wstrm
Copy link
Member

@wstrm wstrm commented Dec 10, 2018 •
edited
Loading

Updates: #115

@coveralls
Copy link

coveralls commented Dec 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 425

  • 0 of 32 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 23.517%
Changes Missing Coverage Covered Lines Changed/Added Lines %
router/router.go 0 32 0.0%
Totals Coverage Status
Change from base Build 419: 0.0%
Covered Lines: 111
Relevant Lines: 472
💛 - Coveralls

@Hjortsberg
Copy link
Member

In progress or review? 😄

@wstrm
Copy link
Member Author

wstrm commented Dec 10, 2018 via email

@wstrm wstrm changed the title refactor+router: move ctrl to router & initial better error handling refactor+router: move controller to router and better error handling Dec 11, 2018
@wstrm wstrm requested a review from Hjortsberg December 11, 2018 12:33
@wstrm wstrm self-assigned this Dec 11, 2018
@wstrm wstrm added Enhancement New feature or request Backend Das hintere Ende labels Dec 11, 2018
@wstrm wstrm merged commit babe04e into master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hjortsberg Hjortsberg Hjortsberg approved these changes

Assignees

@wstrm wstrm

Labels
Backend Das hintere Ende Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wstrm @coveralls @Hjortsberg