Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error shown when leaving Full name empty, but submit button left disabled #210

Open
wstrm opened this issue Jan 8, 2019 · 2 comments
Open

No error shown when leaving Full name empty, but submit button left disabled #210

wstrm opened this issue Jan 8, 2019 · 2 comments
Labels
Bug Something isn't working Frontend Das vordere Ende On hold The ticket/PR is on hold Partially fixed

Comments

@wstrm
Copy link
Member

wstrm commented Jan 8, 2019

According to the API spec. the fullname field is not required, but this isn't throughly tested (I believe most stuff on the frontend will just display an empty full name, should maybe display the username at some places, and not anything in the search results).

So the quickfix in the mean time would be to just require the full name in the frontend, and display an error if empty, and then in the future fix the views.

I believe this one can be on hold.
@wstrm wstrm added Bug Something isn't working On hold The ticket/PR is on hold Frontend Das vordere Ende labels Jan 8, 2019
@wstrm
Copy link
Member Author

wstrm commented Jan 8, 2019

@Hjortsberg, I'll mark this as partially fixed.

@wstrm
Copy link
Member Author

wstrm commented Jan 8, 2019

Partially fixed in #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Frontend Das vordere Ende On hold The ticket/PR is on hold Partially fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wstrm