-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
126-reporting-frontend #143
Conversation
…into 126-reporting-frontend
The requested changes are added. For Yup validation I could not add the error message properly because it would show when you hover over the card rather than when you try to submit without selecting a reason and would disappear when selecting a reason. The validation should still work okay. |
@andrezz-b Checkout the changes if you have time, just tagging you in case you are not getting the notifications. |
Yeah, I get a notification on my phone when you tag me, but for other stuff I get an email and sometimes a notification doesn't arrive. |
Co-authored-by: Andrej Božić <abozic389@gmail.com>
…into 126-reporting-frontend
It's okay, I just want to try and see if this pull request can be resolved today. I added the changes you suggested, is everything okay now? |
It's fine now, I'll merge it after the presentation. |
User reporting should be implemented fully now. So you can just go to a user you matched with and try reporting them, to test it out.