Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

126-reporting-frontend #143

Merged
merged 10 commits into from
Jun 10, 2024
Merged

126-reporting-frontend #143

merged 10 commits into from
Jun 10, 2024

Conversation

SaraKalcic
Copy link
Collaborator

User reporting should be implemented fully now. So you can just go to a user you matched with and try reporting them, to test it out.

@SaraKalcic SaraKalcic added this to the Project end 🌟 milestone Jun 8, 2024
@SaraKalcic SaraKalcic requested a review from andrezz-b June 8, 2024 22:43
@SaraKalcic SaraKalcic self-assigned this Jun 8, 2024
@SaraKalcic SaraKalcic linked an issue Jun 8, 2024 that may be closed by this pull request
@SaraKalcic
Copy link
Collaborator Author

@andrezz-b

frontend/src/api/users.ts Outdated Show resolved Hide resolved
frontend/src/components/UserActionsDropdown.tsx Outdated Show resolved Hide resolved
@andrezz-b andrezz-b added for: Web App Issues regarding React web app. type: feature New feature labels Jun 9, 2024
@SaraKalcic
Copy link
Collaborator Author

The requested changes are added. For Yup validation I could not add the error message properly because it would show when you hover over the card rather than when you try to submit without selecting a reason and would disappear when selecting a reason. The validation should still work okay.

@SaraKalcic SaraKalcic requested a review from andrezz-b June 9, 2024 20:00
@SaraKalcic
Copy link
Collaborator Author

@andrezz-b Checkout the changes if you have time, just tagging you in case you are not getting the notifications.

frontend/src/api/users.ts Outdated Show resolved Hide resolved
@andrezz-b
Copy link
Collaborator

@andrezz-b Checkout the changes if you have time, just tagging you in case you are not getting the notifications.

Yeah, I get a notification on my phone when you tag me, but for other stuff I get an email and sometimes a notification doesn't arrive.

SaraKalcic and others added 2 commits June 9, 2024 23:46
Co-authored-by: Andrej Božić <abozic389@gmail.com>
@SaraKalcic
Copy link
Collaborator Author

@andrezz-b Checkout the changes if you have time, just tagging you in case you are not getting the notifications.

Yeah, I get a notification on my phone when you tag me, but for other stuff I get an email and sometimes a notification doesn't arrive.

It's okay, I just want to try and see if this pull request can be resolved today. I added the changes you suggested, is everything okay now?

@andrezz-b
Copy link
Collaborator

It's fine now, I'll merge it after the presentation.

@andrezz-b andrezz-b merged commit dca3c53 into main Jun 10, 2024
@andrezz-b andrezz-b deleted the 126-reporting-frontend branch June 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: Web App Issues regarding React web app. type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporting frontend
2 participants