Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image popup display #119

Merged
merged 6 commits into from
May 5, 2024
Merged

Image popup display #119

merged 6 commits into from
May 5, 2024

Conversation

petra5555
Copy link
Collaborator

I've added image popup functionality.

Test case

On the matches/profile gallery clicking on the image should display a single image.

  • The image should be placed in the center.
  • Clicking outside of the image should close it.
  • Test on different image and screen dimensions

@petra5555 petra5555 added for: Web App Issues regarding React web app. type: feature New feature labels May 4, 2024
@petra5555 petra5555 added this to the Control point 2 🎉 milestone May 4, 2024
@petra5555 petra5555 requested review from andrezz-b and SaraKalcic May 4, 2024 19:43
@petra5555 petra5555 self-assigned this May 4, 2024
@petra5555 petra5555 linked an issue May 4, 2024 that may be closed by this pull request
Displaying images on detailed profile card #86
Closed
andrezz-b
andrezz-b approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@andrezz-b andrezz-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrezz-b andrezz-b linked an issue May 5, 2024 that may be closed by this pull request
Add image gallery #74
Closed
4 tasks
SaraKalcic
SaraKalcic approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@SaraKalcic SaraKalcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrezz-b andrezz-b merged commit b58ded7 into main May 5, 2024
@andrezz-b andrezz-b deleted the image-popup-display branch May 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaraKalcic SaraKalcic SaraKalcic approved these changes

@andrezz-b andrezz-b andrezz-b approved these changes

Assignees

@petra5555 petra5555

Labels
for: Web App Issues regarding React web app. type: feature New feature
Projects
None yet
Milestone
Control point 2 🎉
Development

Successfully merging this pull request may close these issues.

Displaying images on detailed profile card Add image gallery
3 participants
@petra5555 @andrezz-b @SaraKalcic