Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty window after switching in some cases #697

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

zihadmahiuddin
Copy link
Contributor

Purpose of this Pull Request

In some cases, Ribir wouldn't redraw the window even when a redraw event would be emitted.
For example, on my i3 setup if I go to another workspace and come back, the app wouldn't redraw and the window would stay blank.

Here is a video:

2025-02-06.13-09-43.mp4

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

I think changing Window::draw_frame's signature might count as breaking, let me know if it is, I'll edit the change log to reflect that.

@M-Adoo M-Adoo added the B-test Notify bot to start testing label Feb 6, 2025
Copy link
Collaborator

@M-Adoo M-Adoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@M-Adoo M-Adoo enabled auto-merge February 7, 2025 06:21
@M-Adoo M-Adoo added this pull request to the merge queue Feb 7, 2025
Merged via the queue into RibirX:master with commit d6df0f4 Feb 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants