-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/input #684
Merged
Merged
Refactor/input #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da0ed50
to
9a05065
Compare
9a05065
to
7a26834
Compare
7a26834
to
7c4a6b4
Compare
7c4a6b4
to
7954222
Compare
7954222
to
d4572c0
Compare
M-Adoo
reviewed
Dec 27, 2024
M-Adoo
reviewed
Dec 27, 2024
M-Adoo
reviewed
Dec 27, 2024
d4572c0
to
2596841
Compare
2596841
to
6fc20f1
Compare
M-Adoo
reviewed
Jan 3, 2025
6fc20f1
to
1784cb7
Compare
1784cb7
to
adb3d0d
Compare
adb3d0d
to
c59c1e2
Compare
c59c1e2
to
ce60581
Compare
ce60581
to
5088241
Compare
5088241
to
4165221
Compare
0324e2f
to
ea5e83c
Compare
ea5e83c
to
74b2bdc
Compare
M-Adoo
reviewed
Jan 17, 2025
74b2bdc
to
9610d61
Compare
9610d61
to
852e1a6
Compare
852e1a6
to
7523610
Compare
7523610
to
16f8dc5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 83.64% 84.38% +0.74%
==========================================
Files 207 209 +2
Lines 28760 28759 -1
==========================================
+ Hits 24055 24267 +212
+ Misses 4705 4492 -213 ☔ View full report in Codecov by Sentry. |
16f8dc5
to
43d61f0
Compare
43d61f0
to
3b10346
Compare
M-Adoo
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
Please briefly describe what this Pull Request is aiming to achieve.
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.