Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/input #684

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Refactor/input #684

merged 5 commits into from
Jan 17, 2025

Conversation

wjian23
Copy link
Contributor

@wjian23 wjian23 commented Dec 27, 2024

Purpose of this Pull Request

Please briefly describe what this Pull Request is aiming to achieve.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo added the B-test Notify bot to start testing label Dec 27, 2024
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Dec 27, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Dec 27, 2024
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Dec 27, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Dec 27, 2024
widgets/src/input.rs Outdated Show resolved Hide resolved
widgets/src/input.rs Outdated Show resolved Hide resolved
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 3, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 3, 2025
core/src/builtin_widgets.rs Outdated Show resolved Hide resolved
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 13, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 13, 2025
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 13, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 13, 2025
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 13, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 13, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 16, 2025
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 16, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 16, 2025
macros/src/lib.rs Outdated Show resolved Hide resolved
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 17, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 17, 2025
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 17, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 59.58220% with 445 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (bdf7bf0) to head (16f8dc5).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
widgets/src/input/text_editable.rs 51.54% 110 Missing ⚠️
widgets/src/input/text_selection.rs 37.50% 95 Missing ⚠️
widgets/src/input/edit_text.rs 28.12% 46 Missing ⚠️
widgets/src/input.rs 36.50% 40 Missing ⚠️
painter/src/text/typography_store.rs 19.51% 33 Missing ⚠️
widgets/src/select_region.rs 58.82% 21 Missing ⚠️
macros/src/part_state.rs 46.66% 16 Missing ⚠️
themes/material/src/classes/input_cls.rs 39.13% 14 Missing ⚠️
widgets/src/input/text_glyphs.rs 93.83% 13 Missing ⚠️
core/src/builtin_widgets/scrollable.rs 75.55% 11 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   83.64%   84.38%   +0.74%     
==========================================
  Files         207      209       +2     
  Lines       28760    28759       -1     
==========================================
+ Hits        24055    24267     +212     
+ Misses       4705     4492     -213     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 17, 2025
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 17, 2025
@M-Adoo M-Adoo enabled auto-merge January 17, 2025 12:04
@M-Adoo M-Adoo added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 12595b4 Jan 17, 2025
7 checks passed
@M-Adoo M-Adoo deleted the refactor/input branch January 17, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants