-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor jira-config-gen
Command
#163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report bugs in Issues The following are automatically added:
Available user actions:
Supported /retest check runsSupported labels
|
/wip |
jira-config-gen
Commandjira-config-gen
Command
jira-config-gen
Commandjira-config-gen
Command
@calebevans is this PR still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting some work on refactoring firewatch to have a better structure, closer to other tools our team supports (openshift-cli-installer, qe-metrics, etc.). This PR refactors only the
jira-config-gen
command, other PRs will follow.utils/general.py
to hold some general utilitiesrender_jira_config
functionget_file_conents
functionutils/const.py
. Did this to avoid needing to provide a path to the template.