Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light novel and manga with same names creating conflict #15

Open
Arima57 opened this issue Dec 20, 2023 · 1 comment
Open

Light novel and manga with same names creating conflict #15

Arima57 opened this issue Dec 20, 2023 · 1 comment

Comments

@Arima57
Copy link

Arima57 commented Dec 20, 2023

With the increasing number of LN to manga adaptations and vice versa and Anilist APIs inherent inability to tell the two apart, the get_manga and get_manga_id methods seem to be having unexpected behaviors because of the collisions. For the time being, it can SORT of be fixed by a little bit of work and manual selection turned on but separating LN and Manga completely might be a bit tedious without disturbing the existing functionality.

@Arima57
Copy link
Author

Arima57 commented Dec 20, 2023

I'll create a pull request for now with the makeshift fix. (It simply adds a ' (lightnovel)' indicator at the end of lightnovel names during manual selection).

Additionally, I eliminated some boilerplate that was likely unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant