-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cone generator #309
Open
Cabbache
wants to merge
3
commits into
Razaekel:develop
Choose a base branch
from
Cabbache:feature/cone
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add cone generator #309
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
use crate::noise_fns::NoiseFn; | ||
|
||
/// Noise function that outputs a cone. | ||
/// | ||
/// This noise function takes a 2d point and outputs a cone that is aligned along the z axis. | ||
/// The origin has a value of 1 and points with a distance from the origin beyond the radius | ||
/// of the cone are -1. | ||
#[derive(Clone, Copy, Debug)] | ||
pub struct Cone { | ||
/// radius of the cone. | ||
pub radius: f64, | ||
} | ||
|
||
impl Cone { | ||
pub const DEFAULT_RADIUS: f64 = 1.0; | ||
|
||
pub fn new() -> Self { | ||
Self { | ||
radius: Self::DEFAULT_RADIUS, | ||
} | ||
} | ||
|
||
pub fn set_radius(self, radius: f64) -> Self { | ||
Self { radius } | ||
} | ||
} | ||
|
||
impl Default for Cone { | ||
fn default() -> Self { | ||
Self::new() | ||
} | ||
} | ||
|
||
impl NoiseFn<f64, 2> for Cone { | ||
fn get(&self, point: [f64; 2]) -> f64 { | ||
let x = point[0]; | ||
let y = point[1]; | ||
|
||
// Calculate the distance of the point from the origin. | ||
let dist_from_center = (x.powi(2) + y.powi(2)).sqrt(); | ||
|
||
match dist_from_center > self.radius{ | ||
true => -1f64, | ||
false => 1.0 - 2.0*(dist_from_center / self.radius) | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should square the radius (you could even store the squared version) so you can avoid the
sqrt()
call above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I've moved the sqrt call inside the match expression so that it is only computed for case false.