Rewrite Thermal Runaway detection #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralim
force-pushed
the
issue-1946-thermal-runaway-update
branch
from
a05f49a to
c90d312
Compare
Ralim
force-pushed
the
issue-1946-thermal-runaway-update
branch
from
c90d312 to
8f05433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1946.
Rewriting the thermal runaway to look for a low-high delta instead of a rate of change.
This should be more reliable.
Also this only checks until we are confident the hardware isn't broken (for main broken case). So it should avoid false tripping.
This is a tradeoff; where we wont detect a runaway immediately, so I have kept the check for the ADC going off the charts to find a runaway tip.
This will need TESTING for confidence. But I'm posting this early for testing feedback.
What is the new behaviour (if this is a feature change)?
Other information: