ravedude: Don't emit non-ascii bytes on Windows #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows console stdio does not support sending UTF-8 sequences which means that we must ensure that any data received from the serial connection is cleaned to ASCII only before forwarding it to the console. To make sure that users notice the illegal data getting sent, print `?` symbols instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows console stdio does not support sending UTF-8 sequences which means that we must ensure that any data received from the serial connection is cleaned to ASCII only before forwarding it to the console.
To make sure that users notice the illegal data getting sent, print
?symbols instead.Fixes #515.
@BiasedKiwi, please give this branch a try using