Skip to content

attiny84a: add chip #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

attiny84a: add chip #143

merged 3 commits into from
Dec 11, 2023

Conversation

MichaelDarr
Copy link
Contributor

@MichaelDarr MichaelDarr commented Nov 29, 2023

These changes implement basic ATtiny84a support.

Signed-off-by: Michael Darr <michael.e.darr@gmail.com>
@Rahix
Copy link
Owner

Rahix commented Nov 30, 2023

Sounds good, ping me once you want me to review and merge :)

@MichaelDarr MichaelDarr marked this pull request as ready for review December 1, 2023 14:21
@MichaelDarr
Copy link
Contributor Author

@Rahix - looks like everything works! I think this is ready for review.

Signed-off-by: Michael Darr <michael.e.darr@gmail.com>
@MichaelDarr
Copy link
Contributor Author

MichaelDarr commented Dec 5, 2023

@Rahix - I've included the eeprom patch for the ATtiny84a in this PR. After making corresponding updates to my local copies of attiny-hal and avr-hal-generic, and the avr-hal eeprom r/w abstractions worked right away! I plan on opening a corresponding PR over there, but those contribution guidelines are a bit less concrete. Is there anything I should be aware of before opening the PR?

Update: I opened a PR

… into attiny84a-support

Signed-off-by: Michael Darr <michael.e.darr@gmail.com>
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looking good and thanks a lot for the contribution! :)

@Rahix Rahix merged commit 3deda0c into Rahix:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants