Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to caption from module if instance caption is missing #5

Closed
Rahix opened this issue Aug 25, 2020 · 1 comment · Fixed by #15
Closed

Fall back to caption from module if instance caption is missing #5

Rahix opened this issue Aug 25, 2020 · 1 comment · Fixed by #15
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Rahix
Copy link
Owner

Rahix commented Aug 25, 2020

From Rahix/avr-device#26

@jwagen: There is also an issue that module list contain the caption attribute of that module, but the instances of that module does not contain the caption attribute. Currently atdf2svd expects it to be on the instance.

@Rahix: Would adding a fall-back for the other tag fix this, or is a more elaborate distinction needed?

@jwagen: Yes a fall-back does seem to be sufficient. So I don't think something more elaborate is necessary at least for now.

@Rahix Rahix added the help wanted Extra attention is needed label Aug 25, 2020
@Rahix Rahix added the good first issue Good for newcomers label Oct 2, 2020
@Rahix
Copy link
Owner Author

Rahix commented Nov 17, 2020

Here,

description: instance.attr("caption").ok().cloned(),

only the caption from the <instance ...> is used. That's where a fallback to the <module ...> which is parsed further up should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant