Eliminate some redundant WebGPU buffer writes #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huh, this doesn't make any sense at all... The scenewide uniform data needs to be updated once per frame, not once per mesh. Perhaps this was supposed to be per-material or even per-mesh data, but I think it's just a copy/paste error. Caught this thanks to tracing API calls, so `etrace` already paid off... These writes are wasteful and can safely be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huh, this doesn't make any sense at all... The scenewide uniform data needs to be updated once per frame, not once per mesh. Perhaps this was supposed to be per-material or even per-mesh data, but I think it's just a copy/paste error.
Caught this thanks to tracing API calls, so
etracealready paid off... These writes are wasteful and can safely be removed.