Merge pull request #371 from RagnarokResearchLab/shader-transparency-fix

Fix an unintended type conversion in the terrain shader
RagnarokResearchLab · Feb 13, 2024 · 357e064 · 357e064
2 parents 9aa1583 + b7e9b92
commit 357e064
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Core/NativeClient/WebGPU/Shaders/TerrainGeometryShader.wgsl b/Core/NativeClient/WebGPU/Shaders/TerrainGeometryShader.wgsl
@@ -137,7 +137,7 @@ fn vs_main(in: VertexInput) -> VertexOutput {
 
 // Magenta background pixels should be discarded (but pre-processing on the CPU is expensive)
 fn isTransparentBackgroundPixel(diffuseTextureColor : vec4f) -> bool {
-	return (diffuseTextureColor.r >= 254/255 && diffuseTextureColor.g <= 3/255 && diffuseTextureColor.b >= 254/255);
+	return (diffuseTextureColor.r >= 254.0/255.0 && diffuseTextureColor.g <= 3.0/255.0 && diffuseTextureColor.b >= 254.0/255.0);
 }
 
 @fragment
@@ -149,7 +149,7 @@ fn fs_main(in: VertexOutput) -> @location(0) vec4f {
 	let ambientColor = uPerSceneData.ambientLight.rgb;
 
 	if (isTransparentBackgroundPixel(diffuseTextureColor)) {
-		diffuseTextureColor.a = 0.0;
+		discard;
 	}
 
 	let lightmapTexCoords = in.lightmapTextureCoords;