Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: macOS fixes #323

Closed
wants to merge 2 commits into from
Closed

build: macOS fixes #323

wants to merge 2 commits into from

Conversation

jlopez
Copy link

@jlopez jlopez commented Jul 1, 2024

  • build: do not use threads on macOS builds
  • build: fix macOS compile warnings

jlopez added 2 commits July 1, 2024 09:49
@jlopez
build: do not use threads on macOS builds
814ae29 
Avoids compile issue due to lack of `pthread_getattr_np` function.
@jlopez
build: fix macOS compile warnings
1d726a8
@randomdude999
Copy link
Collaborator

the correct fix is to use osx specific pthread functions, instead of disabling all usage of threads. seem to be pthread_get_stackaddr_np and pthread_get_stacksize_np, though they aren't particularly well-documented. but i guess i can cherry-pick the warning fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlopez @randomdude999