Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor model selection on histograms #50

Open
supazel opened this issue Aug 22, 2019 · 4 comments
Open

Poor model selection on histograms #50

supazel opened this issue Aug 22, 2019 · 4 comments
Assignees
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@supazel
Copy link
Collaborator

supazel commented Aug 22, 2019

Suggested configuration according to BIC is wrong
In the Histogram analysis tap, state configuration, the suggested configuration according to the BIC criteria is wrong.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Histogram analysis'
  2. Click on 'Start analysis'
  3. See suggested configuration

Desktop (please complete the following information):

  • Windows 10
  • Matlab Version 2017a
  • MASH-FRET Version 1.1.2

Susann Zelger-Paulus
susann.paulus@uzh.ch
20190822_error_BIC.pptx

@supazel supazel added the bug Something isn't working label Aug 22, 2019
@mca-sh
Copy link
Collaborator

mca-sh commented Aug 24, 2019

Hi supazel,
Thank you for the report.
What is it you observed that makes you think the suggested state configuration is wrong?
May be it is a misinterpretation of the BIC plot.
On the pptx you attached, the axis BIC=0 is located on the right and the minimum BIC is obtained for 1 state (the longest bar).

@mca-sh
Copy link
Collaborator

mca-sh commented Nov 28, 2019

Hi supazel,
I understand that the suggested configuration is not satisfying, and that by eye, two Gaussians would seem to describe the histogram better.
However, it seems to be a limitation from the method used in MASH-FRET.
Could you send me the corresponding .mash file so I can verrify this?
Thank you again for the report.

@mca-sh mca-sh added the wontfix This will not be worked on label Jan 10, 2020
@pflanzenhueter
Copy link
Member

Dear all,
can we close this case?
Best wishes
Richard

@mca-sh
Copy link
Collaborator

mca-sh commented Nov 30, 2020

Hi Richard,
I was thinking of leaving it open to anybody who is having the same concern
Mélodie

@mca-sh mca-sh changed the title MASH-FRET bug report Poor model selection on histograms Aug 19, 2022
@mca-sh mca-sh added invalid This doesn't seem right and removed bug Something isn't working invalid This doesn't seem right labels Aug 19, 2022
@mca-sh mca-sh added the invalid This doesn't seem right label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants