Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the constant fields name finder (renamed from enum fields) #9

Merged
merged 14 commits into from
Jan 10, 2024

Conversation

IotaBread
Copy link
Member

@IotaBread IotaBread commented Dec 29, 2023

Now names are searched recursively, and strings passed to constructors are properly detected

@IotaBread IotaBread added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 29, 2023
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some licenses need updating

@IotaBread
Copy link
Member Author

The header is set to just display the creation year, should I change it?

@OroArmor
Copy link
Member

OroArmor commented Jan 5, 2024

Not sure. I thought QSL used a range from creation to current, but not sure

@IotaBread
Copy link
Member Author

It doesn't

@IotaBread IotaBread merged commit 3ca9975 into QuiltMC:master Jan 10, 2024
2 checks passed
@IotaBread IotaBread deleted the constant-fields branch January 10, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants