Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Enigma 2.0 #8

Merged
merged 12 commits into from
Dec 28, 2023
Merged

Update to Enigma 2.0 #8

merged 12 commits into from
Dec 28, 2023

Conversation

IotaBread
Copy link
Member

Depends on QuiltMC/enigma#168

IotaBread
IotaBread commented Dec 7, 2023
View reviewed changes
settings.gradle Outdated Show resolved Hide resolved
@ix0rai
Copy link
Member

ix0rai commented Dec 15, 2023

we should change the package to enigma_plugin to match conventions

@IotaBread IotaBread marked this pull request as ready for review December 21, 2023 19:11
ix0rai
ix0rai approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! I'm not super knowledgeable about the plugin, but all this looks great.
I'm going to put checkstyle on here before I merge this because I'm just Like That

@ix0rai ix0rai merged commit dc30739 into QuiltMC:master Dec 28, 2023
2 checks passed
@IotaBread IotaBread deleted the enigma-2.0 branch January 10, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IotaBread @ix0rai