Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative paths in the API wrapper #305

Closed
wants to merge 8 commits into from
Closed

Relative paths in the API wrapper #305

wants to merge 8 commits into from

Conversation

aktech
Copy link
Member

@aktech aktech commented Feb 2, 2024 •
edited
Loading

  • Fixes relative paths in the API wrapper
  • Adds a proxy_url: for deployed environments, where the app is created on a particular port and deployed on a different url via a proxy.

@aktech aktech marked this pull request as ready for review February 27, 2024 21:23
pmeier
pmeier approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the only change is that we append the root path to the API URL for the UI, correct?

I'm ok with merging as is, but I would prefer to keep the diff smaller and just fix the api_url that we pass to App.

@pmeier pmeier mentioned this pull request Mar 6, 2024
Merged
@aktech
Copy link
Member Author

aktech commented Mar 6, 2024

closing in favor of #346

@aktech aktech closed this Mar 6, 2024
@aktech aktech deleted the relative-path-in-api branch March 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aktech @pmeier