Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reformat allowed document types in upload area #271

Closed
pmeier opened this issue Jan 16, 2024 · 3 comments · Fixed by #319
Closed

Don't reformat allowed document types in upload area #271

pmeier opened this issue Jan 16, 2024 · 3 comments · Fixed by #319
Labels
area: web-ui 💻 good first issue Good for newcomers help wanted Extra attention is needed type: enhancement 💅 New feature or request
Milestone

Comments

@pmeier
Copy link
Member

pmeier commented Jan 16, 2024

Feature description

In the file selection area of the UI, we are currently dropping the leading period and uppercasing the extension of the allowed documents:

config.allowed_documents = [
ext[1:].upper() for ext in components["documents"]
]

Meaning, we are turning .pdf into PDF. This is in line with our Figma designs.

Looking at this screenshot taken from #270

image

I think TXT and PDF are clear enough, but I "stumbled" over MD as I have never seen that before. Had it been .md, I think it would be instantly clear for someone familiar with Markdown. Even if not, they could potentially perform the match when looking at the extension of the file in the file picker.

I want us to look at the design again and see if this was intentional or not. If no, I would like us to just use the plain extension including the leading period.

cc @smeragoel

Value and/or benefit

Less confusion about the possible file formats for the user. This becomes even more relevant if we add more formats in the future, which is planned.

Anything else?

No response

@smeragoel
Copy link

Plain extensions, inlcuding leading periods are fine. Here's the updated design:

image

I also changed the text a little bit to make it sound 'smoother'

@pmeier
Copy link
Member Author

pmeier commented Jan 16, 2024

@smeragoel You can drop the [max. 10MB] from the design. We have a workaround in place and with that we are no longer limited in file size.

@pmeier pmeier added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 16, 2024
@smeragoel
Copy link

Fixed!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: web-ui 💻 good first issue Good for newcomers help wanted Extra attention is needed type: enhancement 💅 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants